Bug 118477

Summary:

[Mac] every enabled text track should be listed in the track menu

Product:

WebKit

Reporter:

Eric Carlson <eric.carlson>

Component:

Media

Assignee:

Eric Carlson <eric.carlson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, cdumez, commit-queue, dino, esprehn+autocc, glenn, gyuyoung.kim, jer.noble, rakuco, rniwa

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch	jer.noble: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2	none
Updated patch	none

Eric Carlson

Reported 2013-07-08 10:21:54 PDT

The logic that chooses text tracks for the track menu does not consider whether or not a track is visible, so it is possible for a track that is enabled and displaying cues to not be in the menu. This will cause a confusing user experience.

Attachments
Proposed patch (8.78 KB, patch) 2013-07-08 10:36 PDT, Eric Carlson	jer.noble: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion (776.93 KB, application/zip) 2013-07-08 12:22 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 (487.14 KB, application/zip) 2013-07-08 17:38 PDT, Build Bot	no flags	Details
Updated patch (14.34 KB, patch) 2013-07-09 09:47 PDT, Eric Carlson	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Eric Carlson

Comment 1 2013-07-08 10:31:19 PDT

<rdar://problem/13832062>

Eric Carlson

Comment 2 2013-07-08 10:36:03 PDT

Created attachment 206258 [details] Proposed patch

Build Bot

Comment 3 2013-07-08 12:22:41 PDT

Comment on attachment 206258 [details] Proposed patch Attachment 206258 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/987835 New failing tests: media/video-controls-captions-trackmenu-includes-enabled-track.html

Build Bot

Comment 4 2013-07-08 12:22:43 PDT

Created attachment 206263 [details] Archive of layout-test-results from webkit-ews-04 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-04 Port: mac-mountainlion Platform: Mac OS X 10.8.3

Build Bot

Comment 5 2013-07-08 17:38:56 PDT

Comment on attachment 206258 [details] Proposed patch Attachment 206258 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/864468 New failing tests: media/video-controls-captions-trackmenu-includes-enabled-track.html

Build Bot

Comment 6 2013-07-08 17:38:58 PDT

Created attachment 206286 [details] Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-11 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.3

Eric Carlson

Comment 7 2013-07-09 09:47:57 PDT

Created attachment 206332 [details] Updated patch

WebKit Commit Bot

Comment 8 2013-07-10 14:04:23 PDT

Comment on attachment 206332 [details] Updated patch Clearing flags on attachment: 206332 Committed r152547: <http://trac.webkit.org/changeset/152547>

WebKit Commit Bot

Comment 9 2013-07-10 14:04:28 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.