Summary: | @readonly and @aria-readonly="false" are not exposed correctly to accessibility | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | James Craig <jcraig> | ||||||||||||
Component: | Accessibility | Assignee: | James Craig <jcraig> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | aboxhall, apinheiro, buildbot, cfleizach, commit-queue, dmazzoni, jcraig, jdiggs, mario, rniwa, webkit-bug-importer | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
James Craig
2013-07-08 09:49:56 PDT
Created attachment 206271 [details]
patch
Attachment 206271 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/accessibility/aria-readonly-expected.txt', u'LayoutTests/accessibility/aria-readonly.html', u'Source/WebCore/ChangeLog', u'Source/WebCore/accessibility/AccessibilityRenderObject.cpp']" exit_code: 1
Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2713: One line control clauses should not use braces. [whitespace/braces] [4]
Total errors found: 1 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 206273 [details]
patch
Created attachment 206291 [details]
patch, with comment typo corrections
m. no code changes since reviewed. just corrected comments in the test case previously meaning "required" state instead of "readonly."
s/meaning/mentioning/ Comment on attachment 206291 [details] patch, with comment typo corrections Rejecting attachment 206291 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 206291, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.appspot.com/results/892626 Comment on attachment 206291 [details] patch, with comment typo corrections Attachment 206291 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/909548 New failing tests: fullscreen/full-screen-iframe-with-max-width-height.html Created attachment 206308 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.3
Created attachment 206325 [details]
patch, adding the "Reviewed by NOBODY" string accidentally removed from the changelog
Comment on attachment 206325 [details] patch, adding the "Reviewed by NOBODY" string accidentally removed from the changelog Clearing flags on attachment: 206325 Committed r152522: <http://trac.webkit.org/changeset/152522> All reviewed patches have been landed. Closing bug. |