Bug 118466

Summary: Add Deque::removeLast
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch kling: review+

Antti Koivisto
Reported 2013-07-08 05:22:07 PDT
Deque can remove both the first and the last element efficiently.
Attachments
patch (2.35 KB, patch)
2013-07-08 05:25 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (2.35 KB, patch)
2013-07-08 05:28 PDT, Antti Koivisto 		kling: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2013-07-08 05:25:12 PDT
Created attachment 206231 [details] patch
Antti Koivisto
Comment 2 2013-07-08 05:27:35 PDT
Comment on attachment 206231 [details] patch wrong patch
Antti Koivisto
Comment 3 2013-07-08 05:28:09 PDT
Created attachment 206233 [details] patch
Andreas Kling
Comment 4 2013-07-08 05:36:03 PDT
Comment on attachment 206233 [details] patch r=me, though we should also improve remove() some day.. Also, this could use an API test.
Antti Koivisto
Comment 5 2013-07-08 06:23:48 PDT
http://trac.webkit.org/changeset/152449 (with API test)
Note You need to log in before you can comment on or make changes to this bug.