Bug 118454 – [EFL] Enable CSS Image Orientation

• Component: WebKit EFL
• Status: RESOLVED WONTFIX

[Gyuyoung Kim]

SSIA. But, this bug will be used to keep WIP patches mainly.

[Gyuyoung Kim]

Created attachment 206211 [details]
WIP-1

[WebKit Commit Bot]

Attachment 206211 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/html/HTMLCanvasElement.cpp', u'Source/WebCore/loader/cache/CachedImage.cpp', u'Source/WebCore/page/DragController.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/platform/DragImage.h', u'Source/WebCore/platform/efl/DragImageEfl.cpp', u'Source/WebCore/platform/graphics/BitmapImage.cpp', u'Source/WebCore/platform/graphics/BitmapImage.h', u'Source/WebCore/platform/graphics/GraphicsContext.cpp', u'Source/WebCore/platform/graphics/GraphicsContext.h', u'Source/WebCore/platform/graphics/ImageSource.cpp', u'Source/WebCore/platform/graphics/ImageSource.h', u'Source/WebCore/platform/graphics/cairo/ImageBufferCairo.cpp', u'Source/WebCore/platform/mac/DragImageMac.mm', u'Source/WebCore/rendering/RenderImage.cpp', u'Source/WebCore/rendering/style/RenderStyle.cpp', u'Tools/Scripts/webkitperl/FeatureList.pm']" exit_code: 1
Source/WebCore/platform/DragImage.h:78:  The parameter name "orientation" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/loader/cache/CachedImage.cpp:259:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/loader/cache/CachedImage.cpp:260:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/loader/cache/CachedImage.cpp:263:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/loader/cache/CachedImage.cpp:264:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 5 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Early Warning System Bot]

Comment on attachment 206211 [details]
WIP-1

Attachment 206211 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1048215

[Early Warning System Bot]

Comment on attachment 206211 [details]
WIP-1

Attachment 206211 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/976920

[EFL EWS Bot]

Comment on attachment 206211 [details]
WIP-1

Attachment 206211 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/977702

[kov's GTK+ EWS bot]

Comment on attachment 206211 [details]
WIP-1

Attachment 206211 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/975163

[EFL EWS Bot]

Comment on attachment 206211 [details]
WIP-1

Attachment 206211 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1002250

[Build Bot]

Comment on attachment 206211 [details]
WIP-1

Attachment 206211 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1031223

[Build Bot]

Comment on attachment 206211 [details]
WIP-1

Attachment 206211 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/988169

[Gyuyoung Kim]

Created attachment 206243 [details]
WIP-2

[Gyuyoung Kim]

Created attachment 206376 [details]
WIP-3

[Gyuyoung Kim]

Created attachment 206515 [details]
WIP-4

[Gyuyoung Kim]

Created attachment 206593 [details]
WIP-5 pass efl and gtk ports

[Gyuyoung Kim]

Created attachment 206718 [details]
WIP-6 (EFL, GTK and Mac ports)

[Early Warning System Bot]

Comment on attachment 206718 [details]
WIP-6 (EFL, GTK and Mac ports)

Attachment 206718 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1080055

[Early Warning System Bot]

Comment on attachment 206718 [details]
WIP-6 (EFL, GTK and Mac ports)

Attachment 206718 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1095002

[Build Bot]

Comment on attachment 206718 [details]
WIP-6 (EFL, GTK and Mac ports)

Attachment 206718 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/1103365

[Build Bot]

Comment on attachment 206718 [details]
WIP-6 (EFL, GTK and Mac ports)

Attachment 206718 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1098655

New failing tests:
fast/canvas/pattern-with-transform.html
fast/canvas/canvas-pattern-modify.html
http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html
webgl/conformance/extensions/oes-texture-float-with-canvas.html
canvas/philip/tests/2d.pattern.modify.canvas2.html
fast/canvas/webgl/tex-image-webgl.html
canvas/philip/tests/2d.pattern.paint.orientation.canvas.html
fast/canvas/canvas-pattern-behaviour.html
canvas/philip/tests/2d.pattern.modify.canvas1.html
http/tests/inspector/inspect-element.html
fast/canvas/webgl/texture-npot.html
canvas/philip/tests/initial.reset.pattern.html
webgl/conformance/textures/gl-teximage.html
webgl/conformance/context/premultiplyalpha-test.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgba5551.html
editing/pasteboard/copy-image-with-alt-text.html
canvas/philip/tests/2d.pattern.basic.canvas.html
webgl/conformance/more/functions/texSubImage2DHTMLBadArgs.html
fast/canvas/webgl/tex-sub-image-2d-bad-args.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgba4444.html
webgl/conformance/glsl/samplers/glsl-function-texture2dproj.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgb565.html
fast/canvas/webgl/texture-active-bind.html
fast/canvas/webgl/canvas-2d-webgl-texture.html

[Build Bot]

Created attachment 207014 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.3

[Gyuyoung Kim]

Created attachment 207075 [details]
WIP-7

[Early Warning System Bot]

Comment on attachment 207075 [details]
WIP-7

Attachment 207075 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1104798

[Early Warning System Bot]

Comment on attachment 207075 [details]
WIP-7

Attachment 207075 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1106825

[Build Bot]

Comment on attachment 207075 [details]
WIP-7

Attachment 207075 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1104799

[Build Bot]

Comment on attachment 207075 [details]
WIP-7

Attachment 207075 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1100735

[Build Bot]

Comment on attachment 207075 [details]
WIP-7

Attachment 207075 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/1110823

[Gyuyoung Kim]

Created attachment 207181 [details]
WIP-8

[Build Bot]

Comment on attachment 207181 [details]
WIP-8

Attachment 207181 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1080442

New failing tests:
fast/canvas/pattern-with-transform.html
webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgb565.html
http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html
webgl/conformance/extensions/oes-texture-float-with-canvas.html
canvas/philip/tests/2d.pattern.modify.canvas2.html
fast/canvas/webgl/tex-image-webgl.html
canvas/philip/tests/2d.pattern.paint.orientation.canvas.html
fast/canvas/canvas-pattern-behaviour.html
canvas/philip/tests/2d.pattern.modify.canvas1.html
http/tests/inspector/inspect-element.html
fast/canvas/webgl/texture-npot.html
canvas/philip/tests/initial.reset.pattern.html
webgl/conformance/textures/gl-teximage.html
webgl/conformance/context/premultiplyalpha-test.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgba5551.html
editing/pasteboard/copy-image-with-alt-text.html
canvas/philip/tests/2d.pattern.basic.canvas.html
webgl/conformance/more/functions/texSubImage2DHTMLBadArgs.html
fast/canvas/webgl/tex-sub-image-2d-bad-args.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgba4444.html
fast/canvas/webgl/premultiplyalpha-test.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgb565.html
fast/canvas/webgl/texture-active-bind.html
fast/canvas/webgl/canvas-2d-webgl-texture.html

[Build Bot]

Created attachment 207238 [details]
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-11  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.3

[Build Bot]

Comment on attachment 207181 [details]
WIP-8

Attachment 207181 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/1139261

[Build Bot]

Comment on attachment 207181 [details]
WIP-8

Attachment 207181 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1289908

New failing tests:
fast/canvas/webgl/premultiplyalpha-test.html
fast/canvas/pattern-with-transform.html
fast/canvas/canvas-pattern-modify.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgb565.html
fast/canvas/webgl/tex-sub-image-2d-bad-args.html
canvas/philip/tests/initial.reset.pattern.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgba4444.html
canvas/philip/tests/2d.pattern.modify.canvas2.html
fast/css/font-face-data-uri.html
fast/canvas/webgl/tex-image-webgl.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgba5551.html
fast/canvas/webgl/canvas-2d-webgl-texture.html
canvas/philip/tests/2d.pattern.paint.orientation.canvas.html
fast/canvas/canvas-pattern-behaviour.html
canvas/philip/tests/2d.pattern.modify.canvas1.html
canvas/philip/tests/2d.pattern.basic.canvas.html
http/tests/inspector/inspect-element.html

[Build Bot]

Created attachment 207884 [details]
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-01  Port: mac-mountainlion  Platform: Mac OS X 10.8.4

[Michael Catanzaro]

Closing this bug because the EFL port has been removed from trunk.

If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this.