Bug 118428

Summary: [Windows] Add logic to identify build-time feature set
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebCore Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andersca, apinheiro, benjamin, bfulgham, cfleizach, cmarcelo, commit-queue, dmazzoni, jdiggs, mario, zarvai
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Remove unrelated test result from previous patch. andersca: review+

Brent Fulgham
Reported 2013-07-05 10:49:13 PDT
Certain features are only present when building with newer SDK versions. This patch adds a handful of tests to the build system to identify what OS level is being targeted so that only the features supported by the current build environment are integrated into WebKit.
Attachments
Patch (6.27 KB, patch)
2013-07-05 10:54 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Remove unrelated test result from previous patch. (5.86 KB, patch)
2013-07-05 10:56 PDT, Brent Fulgham 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2013-07-05 10:54:31 PDT
Created attachment 206161 [details] Patch
Brent Fulgham
Comment 2 2013-07-05 10:56:53 PDT
Created attachment 206162 [details] Remove unrelated test result from previous patch.
Anders Carlsson
Comment 3 2013-07-05 13:50:40 PDT
Comment on attachment 206162 [details] Remove unrelated test result from previous patch. View in context: https://bugs.webkit.org/attachment.cgi?id=206162&action=review > Source/WebCore/ChangeLog:9 > + * WebCorePrefix.h: Activate MSVC 2010 workarounds for CGFLoat if CGFloat.
Brent Fulgham
Comment 4 2013-07-05 14:43:19 PDT
(In reply to comment #3) > (From update of attachment 206162 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=206162&action=review > > > Source/WebCore/ChangeLog:9 > > + * WebCorePrefix.h: Activate MSVC 2010 workarounds for CGFLoat if > > CGFloat. Done!
Brent Fulgham
Comment 5 2013-07-05 15:23:46 PDT
Committed r152426: <http://trac.webkit.org/changeset/152426>
Zoltan Arvai
Comment 6 2013-07-08 02:10:08 PDT
A buildfix landed for Qt Win in https://trac.webkit.org/changeset/152445. WTFHeaderDetection.h is not generating on Qt Win.
Note You need to log in before you can comment on or make changes to this bug.