Bug 118414

Summary: Stop hardcoding interfaces that have indexed getters returning strings
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, haraken, laszlo.gombos, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP patch
none
Patch none

Chris Dumez
Reported 2013-07-05 07:21:43 PDT
Interfaces that have indexed getters returning strings are currently hardcoded in the JSC bindings generator's IndexGetterReturnsStrings() subroutine. Now that we support the latest Web IDL indexed getter format, the generator can be smarter and detect if the returned type is a DOMString on its own (since it is specified in the Web IDL).
Attachments
WIP patch (2.25 KB, patch)
2013-07-05 07:22 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (3.26 KB, patch)
2013-07-05 07:52 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2013-07-05 07:22:30 PDT
Created attachment 206148 [details] WIP patch
Chris Dumez
Comment 2 2013-07-05 07:52:57 PDT
Created attachment 206151 [details] Patch
Kentaro Hara
Comment 3 2013-07-05 17:11:16 PDT
Comment on attachment 206151 [details] Patch ok
WebKit Commit Bot
Comment 4 2013-07-06 00:25:31 PDT
Comment on attachment 206151 [details] Patch Clearing flags on attachment: 206151 Committed r152435: <http://trac.webkit.org/changeset/152435>
WebKit Commit Bot
Comment 5 2013-07-06 00:25:33 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.