Summary: | Introduce DECLARE_FORWARDING_ATTRIBUTE_EVENT_LISTENER() macro | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
Component: | SVG | Assignee: | Chris Dumez <cdumez> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, darin, d-r, eflews.bot, esprehn+autocc, fmalita, gtk-ews, gyuyoung.kim, kangil.han, krit, laszlo.gombos, mikhail.pozdnyakov, pdr, philn, rniwa, rwlbuis, schenney, webkit-ews, xan.lopez, zimmermann | ||||||
Priority: | P2 | Keywords: | BlinkMergeCandidate | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 107386 | ||||||||
Attachments: |
|
Description
Chris Dumez
2013-07-05 00:43:21 PDT
Created attachment 206125 [details]
Patch
Attachment 206125 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/dom/EventTarget.h', u'Source/WebCore/svg/SVGElementInstance.cpp', u'Source/WebCore/svg/SVGElementInstance.h']" exit_code: 1
Source/WebCore/dom/EventTarget.h:176: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4]
Source/WebCore/dom/EventTarget.h:180: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4]
Source/WebCore/dom/EventTarget.h:182: More than one command on the same line in if [whitespace/parens] [4]
Total errors found: 3 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 206125 [details] Patch Attachment 206125 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1007407 Comment on attachment 206125 [details] Patch Attachment 206125 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/942936 Comment on attachment 206125 [details] Patch Attachment 206125 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/1004414 Comment on attachment 206125 [details] Patch Attachment 206125 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/1037051 Created attachment 206126 [details]
Patch
Attachment 206126 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/dom/EventTarget.h', u'Source/WebCore/svg/SVGElementInstance.cpp', u'Source/WebCore/svg/SVGElementInstance.h']" exit_code: 1
Source/WebCore/dom/EventTarget.h:176: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4]
Source/WebCore/dom/EventTarget.h:180: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4]
Source/WebCore/dom/EventTarget.h:182: More than one command on the same line in if [whitespace/parens] [4]
Total errors found: 3 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 206126 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=206126&action=review > Source/WebCore/svg/SVGElementInstance.h:76 > + Document* ownerDocument() const; why? now it is not implicitly inlined. > Source/WebCore/svg/SVGElementInstance.h:155 > + virtual Node* toNode(); same here. Comment on attachment 206126 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=206126&action=review >> Source/WebCore/svg/SVGElementInstance.h:76 >> + Document* ownerDocument() const; > > why? now it is not implicitly inlined. I know but I need to stop including SVGElement.h in this file to prevent a cycle in my next patch. Here the casting from SVGElement* to Document* is an issue with a forward declaration. >> Source/WebCore/svg/SVGElementInstance.h:155 >> + virtual Node* toNode(); > > same here. Well, this one is virtual anyway. Comment on attachment 206126 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=206126&action=review >>> Source/WebCore/svg/SVGElementInstance.h:76 >>> + Document* ownerDocument() const; >> >> why? now it is not implicitly inlined. > > I know but I need to stop including SVGElement.h in this file to prevent a cycle in my next patch. Here the casting from SVGElement* to Document* is an issue with a forward declaration. Sorry, casting for the one below. This one is using SVGElement API. (In reply to comment #10) > (From update of attachment 206126 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=206126&action=review > > >> Source/WebCore/svg/SVGElementInstance.h:76 > >> + Document* ownerDocument() const; > > > > why? now it is not implicitly inlined. > > I know but I need to stop including SVGElement.h in this file to prevent a cycle in my next patch. Here the casting from SVGElement* to Document* is an issue with a forward declaration. Agree, that makes sense. > > >> Source/WebCore/svg/SVGElementInstance.h:155 > >> + virtual Node* toNode(); > > > > same here. > > Well, this one is virtual anyway. still it can be inlined if compiler knows the exact class of the object. Comment on attachment 206126 [details]
Patch
Fantastic! This gets us so much closer to axing SVGStyledElement :)
Not marking as cq+ yet in case Mikhail has further comments.
Comment on attachment 206126 [details] Patch Clearing flags on attachment: 206126 Committed r152451: <http://trac.webkit.org/changeset/152451> All reviewed patches have been landed. Closing bug. |