Bug 118404

Summary:

TestWebKitFaviconDatabase/clear-database is not testing things properly

Product:

WebKit

Reporter:

Xabier Rodríguez Calvar <calvaris>

Component:

New Bugs

Assignee:

Xabier Rodríguez Calvar <calvaris>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cgarcia, commit-queue, gustavo, mrobinson

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Xabier Rodríguez Calvar 2013-07-04 19:58:52 PDT

TestWebKitFaviconDatabase/clean-database is not testing things properly

Comment 1 Xabier Rodríguez Calvar 2013-07-04 20:01:20 PDT

Created attachment 206121 [details]
Patch

FiTest checks now for an existing icon and if clean database fails, it should exist and the test should fail. This was not happening so far.

Comment 2 WebKit Commit Bot 2013-07-04 20:03:28 PDT

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

Comment 3 Carlos Garcia Campos 2013-07-04 22:46:58 PDT

Comment on attachment 206121 [details]
Patch

Good catch, thanks! :-)

Comment 4 WebKit Commit Bot 2013-07-05 01:42:20 PDT

Comment on attachment 206121 [details]
Patch

Clearing flags on attachment: 206121

Committed r152410: <http://trac.webkit.org/changeset/152410>

Comment 5 WebKit Commit Bot 2013-07-05 01:42:22 PDT

All reviewed patches have been landed.  Closing bug.