Bug 118403

Summary: [Coordinated Graphics] Rename variables in UpdateAtlas
Product: WebKit Reporter: Jae Hyun Park <jaepark>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cmarcelo, commit-queue, luiz, noam, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2
none
Patch none

Jae Hyun Park
Reported 2013-07-04 18:45:19 PDT
As of r149292, non-composited contents layer was removed from CoordinatedGraphics. So, the variable names should be updated for clarification.
Attachments
Patch (2.92 KB, patch)
2013-07-04 18:46 PDT, Jae Hyun Park 		no flags
DetailsFormatted DiffDiff
Patch (2.94 KB, patch)
2013-07-07 18:59 PDT, Jae Hyun Park 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 (489.37 KB, application/zip)
2013-07-07 21:41 PDT, Build Bot 		no flags
Details
Patch (2.96 KB, patch)
2013-07-08 00:52 PDT, Jae Hyun Park 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jae Hyun Park
Comment 1 2013-07-04 18:46:51 PDT
Created attachment 206118 [details] Patch
Jae Hyun Park
Comment 2 2013-07-07 18:59:06 PDT
Created attachment 206213 [details] Patch
Build Bot
Comment 3 2013-07-07 21:41:55 PDT
Comment on attachment 206213 [details] Patch Attachment 206213 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/970123 New failing tests: http/tests/security/cross-origin-plugin-private-browsing-toggled.html
Build Bot
Comment 4 2013-07-07 21:41:56 PDT
Created attachment 206216 [details] Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.3
Jae Hyun Park
Comment 5 2013-07-07 21:46:11 PDT
The new failing test is not related to this patch.
Noam Rosenthal
Comment 6 2013-07-08 00:25:20 PDT
Comment on attachment 206213 [details] Patch Please call it RootContentsLayer
Jae Hyun Park
Comment 7 2013-07-08 00:52:41 PDT
Created attachment 206222 [details] Patch
Jae Hyun Park
Comment 8 2013-07-08 01:10:56 PDT
(In reply to comment #6) > (From update of attachment 206213 [details]) > Please call it RootContentsLayer Thanks for the review. I updated the patch.
WebKit Commit Bot
Comment 9 2013-07-08 07:13:28 PDT
Comment on attachment 206222 [details] Patch Clearing flags on attachment: 206222 Committed r152450: <http://trac.webkit.org/changeset/152450>
WebKit Commit Bot
Comment 10 2013-07-08 07:13:31 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.