Bug 118387

Summary: Change static_cast<SVGImageElement*> with toSVGImageElement
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: New BugsAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, d-r, esprehn+autocc, fmalita, glenn, ossy, pdr, schenney
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Gyuyoung Kim
Reported 2013-07-04 02:33:17 PDT
As a step to change static_cast with toXXX, static_cast<SVGImageElement*> can be changed with toSVGImageElement(). Blink merge from https://src.chromium.org/viewvc/blink?view=rev&revision=153557
Attachments
Patch (3.96 KB, patch)
2013-07-04 02:37 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2013-07-04 02:37:29 PDT
Created attachment 206069 [details] Patch
WebKit Commit Bot
Comment 2 2013-07-04 06:58:59 PDT
Comment on attachment 206069 [details] Patch Clearing flags on attachment: 206069 Committed r152399: <http://trac.webkit.org/changeset/152399>
WebKit Commit Bot
Comment 3 2013-07-04 06:59:02 PDT
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 4 2013-07-04 08:27:07 PDT
(In reply to comment #2) > (From update of attachment 206069 [details]) > Clearing flags on attachment: 206069 > > Committed r152399: <http://trac.webkit.org/changeset/152399> It broke the debug builds: In file included from /home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/Source/WebCore/rendering/svg/RenderSVGImage.cpp:41:0: /home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/Source/WebCore/svg/SVGImageElement.h: In function 'WebCore::SVGImageElement* WebCore::toSVGImageElement(WebCore::Node*)': [1;31m/home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/Source/WebCore/svg/SVGImageElement.h:81:34: error: 'SVGNames' has not been declared[0m
Chris Dumez
Comment 5 2013-07-04 08:34:42 PDT
(In reply to comment #4) > (In reply to comment #2) > > (From update of attachment 206069 [details] [details]) > > Clearing flags on attachment: 206069 > > > > Committed r152399: <http://trac.webkit.org/changeset/152399> > > It broke the debug builds: > In file included from /home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/Source/WebCore/rendering/svg/RenderSVGImage.cpp:41:0: > /home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/Source/WebCore/svg/SVGImageElement.h: In function 'WebCore::SVGImageElement* WebCore::toSVGImageElement(WebCore::Node*)': > [1;31m/home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/Source/WebCore/svg/SVGImageElement.h:81:34: error: 'SVGNames' has not been declared[0m Build fix landed in <http://trac.webkit.org/changeset/152400>.
Gyuyoung Kim
Comment 6 2013-07-04 18:36:45 PDT
(In reply to comment #5) > Build fix landed in <http://trac.webkit.org/changeset/152400>. I missed to add it. Thank you for the fixing.
Note You need to log in before you can comment on or make changes to this bug.