Summary: | Change static_cast<SVGImageElement*> with toSVGImageElement | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gyuyoung Kim <gyuyoung.kim> | ||||
Component: | New Bugs | Assignee: | Gyuyoung Kim <gyuyoung.kim> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | cdumez, commit-queue, d-r, esprehn+autocc, fmalita, glenn, ossy, pdr, schenney | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Gyuyoung Kim
2013-07-04 02:33:17 PDT
Created attachment 206069 [details]
Patch
Comment on attachment 206069 [details] Patch Clearing flags on attachment: 206069 Committed r152399: <http://trac.webkit.org/changeset/152399> All reviewed patches have been landed. Closing bug. (In reply to comment #2) > (From update of attachment 206069 [details]) > Clearing flags on attachment: 206069 > > Committed r152399: <http://trac.webkit.org/changeset/152399> It broke the debug builds: In file included from /home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/Source/WebCore/rendering/svg/RenderSVGImage.cpp:41:0: /home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/Source/WebCore/svg/SVGImageElement.h: In function 'WebCore::SVGImageElement* WebCore::toSVGImageElement(WebCore::Node*)': [1;31m/home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/Source/WebCore/svg/SVGImageElement.h:81:34: error: 'SVGNames' has not been declared[0m (In reply to comment #4) > (In reply to comment #2) > > (From update of attachment 206069 [details] [details]) > > Clearing flags on attachment: 206069 > > > > Committed r152399: <http://trac.webkit.org/changeset/152399> > > It broke the debug builds: > In file included from /home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/Source/WebCore/rendering/svg/RenderSVGImage.cpp:41:0: > /home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/Source/WebCore/svg/SVGImageElement.h: In function 'WebCore::SVGImageElement* WebCore::toSVGImageElement(WebCore::Node*)': > [1;31m/home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/Source/WebCore/svg/SVGImageElement.h:81:34: error: 'SVGNames' has not been declared[0m Build fix landed in <http://trac.webkit.org/changeset/152400>. (In reply to comment #5) > Build fix landed in <http://trac.webkit.org/changeset/152400>. I missed to add it. Thank you for the fixing. |