Bug 118381

Summary: [GTK] gtk_icon_info_free is deprecated since GTK+ 3.8
Product: WebKit Reporter: Iago Toral <itoral>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: UNCONFIRMED ---    
Severity: Normal CC: bugs-noreply, cgarcia
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed cgarcia: review-, cgarcia: commit-queue-

Description Iago Toral 2013-07-04 01:24:47 PDT
gtk_icon_info_free has been deprecated in favor of g_object_unref. I'll attach patch shortly.
Comment 1 Iago Toral 2013-07-04 01:32:47 PDT
Created attachment 206062 [details]
Proposed
Comment 2 Carlos Garcia Campos 2013-07-04 01:42:21 PDT
Comment on attachment 206062 [details]
Proposed 

We can't do this, we depend on GTK+ 3.6, where GtkIconInfo is not a GObject but a boxed type. We need to add an #ifdef until we bump the required version to 3.8, or we can simply ignore deprecated symbols in gtk versions grater than 3.6. I even proposed a patch to remove the annoying warnings for those cases indeed, see bug #118237.