Summary: | [GTK] gtk_icon_info_free is deprecated since GTK+ 3.8 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Iago Toral <itoral> | ||||||
Component: | WebKitGTK | Assignee: | Claudio Saavedra <csaavedra> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bugs-noreply, cgarcia, csaavedra | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 210100 | ||||||||
Attachments: |
|
Description
Iago Toral
2013-07-04 01:24:47 PDT
Created attachment 206062 [details]
Proposed
Comment on attachment 206062 [details] Proposed We can't do this, we depend on GTK+ 3.6, where GtkIconInfo is not a GObject but a boxed type. We need to add an #ifdef until we bump the required version to 3.8, or we can simply ignore deprecated symbols in gtk versions grater than 3.6. I even proposed a patch to remove the annoying warnings for those cases indeed, see bug #118237. Created attachment 395665 [details]
Patch
Committed r259631: <https://trac.webkit.org/changeset/259631> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395665 [details]. |