Bug 118381

Summary: [GTK] gtk_icon_info_free is deprecated since GTK+ 3.8
Product: WebKit Reporter: Iago Toral <itoral>
Component: WebKitGTKAssignee: Claudio Saavedra <csaavedra>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, cgarcia, csaavedra
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 210100    
Attachments:
Description Flags
Proposed
none
Patch none

Iago Toral
Reported 2013-07-04 01:24:47 PDT
gtk_icon_info_free has been deprecated in favor of g_object_unref. I'll attach patch shortly.
Attachments
Proposed (1.57 KB, patch)
2013-07-04 01:32 PDT, Iago Toral 		no flags
DetailsFormatted DiffDiff
Patch (2.31 KB, patch)
2020-04-07 02:19 PDT, Claudio Saavedra 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Iago Toral
Comment 1 2013-07-04 01:32:47 PDT
Created attachment 206062 [details] Proposed
Carlos Garcia Campos
Comment 2 2013-07-04 01:42:21 PDT
Comment on attachment 206062 [details] Proposed We can't do this, we depend on GTK+ 3.6, where GtkIconInfo is not a GObject but a boxed type. We need to add an #ifdef until we bump the required version to 3.8, or we can simply ignore deprecated symbols in gtk versions grater than 3.6. I even proposed a patch to remove the annoying warnings for those cases indeed, see bug #118237.
Claudio Saavedra
Comment 3 2020-04-07 02:19:23 PDT
Created attachment 395665 [details] Patch
EWS
Comment 4 2020-04-07 02:47:42 PDT
Committed r259631: <https://trac.webkit.org/changeset/259631> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395665 [details].
Note You need to log in before you can comment on or make changes to this bug.