Bug 118379

Summary: [EFL] Gardening. Unskip tests related with editing
Product: WebKit Reporter: KyungTae Kim <ktf.kim>
Component: WebKit EFLAssignee: KyungTae Kim <ktf.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, gyuyoung.kim, lucas.de.marchi, rakuco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

KyungTae Kim
Reported 2013-07-04 00:00:43 PDT
Passed after 150289: editing/selection/doubleclick-beside-cr-span.html editing/selection/doubleclick-whitespace.html Passed after 151626: editing/style/5065910.html
Attachments
Patch (2.55 KB, patch)
2013-07-04 00:14 PDT, KyungTae Kim 		no flags
DetailsFormatted DiffDiff
Patch for landing (15.76 KB, patch)
2013-07-04 01:08 PDT, KyungTae Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
KyungTae Kim
Comment 1 2013-07-04 00:14:26 PDT
Created attachment 206056 [details] Patch
Chris Dumez
Comment 2 2013-07-04 00:26:02 PDT
Comment on attachment 206056 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=206056&action=review > LayoutTests/platform/efl/TestExpectations:-470 > -editing/style/5065910.html [ Missing ] The expected result for this test is wrong. I did not check the others but please do.
KyungTae Kim
Comment 3 2013-07-04 00:48:06 PDT
Comment on attachment 206056 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=206056&action=review >> LayoutTests/platform/efl/TestExpectations:-470 >> -editing/style/5065910.html [ Missing ] > > The expected result for this test is wrong. I did not check the others but please do. You're right. The expected result is wrong because 'paste' is not supported for EFL port now. In this case, should we remain it as 'Missing' and remove the expected result for that?
Chris Dumez
Comment 4 2013-07-04 00:56:02 PDT
Comment on attachment 206056 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=206056&action=review >>> LayoutTests/platform/efl/TestExpectations:-470 >>> -editing/style/5065910.html [ Missing ] >> >> The expected result for this test is wrong. I did not check the others but please do. > > You're right. The expected result is wrong because 'paste' is not supported for EFL port now. > In this case, should we remain it as 'Missing' and remove the expected result for that? Yes, let's remove the wrong expected result.
Chris Dumez
Comment 5 2013-07-04 00:56:56 PDT
FYI, such patch don't need review, just cq. You can remove the "Reviewed By" line from the changelog and set cq flag only.
KyungTae Kim
Comment 6 2013-07-04 01:08:33 PDT
Created attachment 206059 [details] Patch for landing
WebKit Commit Bot
Comment 7 2013-07-04 02:05:51 PDT
Comment on attachment 206059 [details] Patch for landing Clearing flags on attachment: 206059 Committed r152394: <http://trac.webkit.org/changeset/152394>
WebKit Commit Bot
Comment 8 2013-07-04 02:05:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.