Summary: | [EFL] Gardening. Unskip tests related with editing | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | KyungTae Kim <ktf.kim> | ||||||
Component: | WebKit EFL | Assignee: | KyungTae Kim <ktf.kim> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cdumez, commit-queue, gyuyoung.kim, lucas.de.marchi, rakuco | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
KyungTae Kim
2013-07-04 00:00:43 PDT
Created attachment 206056 [details]
Patch
Comment on attachment 206056 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=206056&action=review > LayoutTests/platform/efl/TestExpectations:-470 > -editing/style/5065910.html [ Missing ] The expected result for this test is wrong. I did not check the others but please do. Comment on attachment 206056 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=206056&action=review >> LayoutTests/platform/efl/TestExpectations:-470 >> -editing/style/5065910.html [ Missing ] > > The expected result for this test is wrong. I did not check the others but please do. You're right. The expected result is wrong because 'paste' is not supported for EFL port now. In this case, should we remain it as 'Missing' and remove the expected result for that? Comment on attachment 206056 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=206056&action=review >>> LayoutTests/platform/efl/TestExpectations:-470 >>> -editing/style/5065910.html [ Missing ] >> >> The expected result for this test is wrong. I did not check the others but please do. > > You're right. The expected result is wrong because 'paste' is not supported for EFL port now. > In this case, should we remain it as 'Missing' and remove the expected result for that? Yes, let's remove the wrong expected result. FYI, such patch don't need review, just cq. You can remove the "Reviewed By" line from the changelog and set cq flag only. Created attachment 206059 [details]
Patch for landing
Comment on attachment 206059 [details] Patch for landing Clearing flags on attachment: 206059 Committed r152394: <http://trac.webkit.org/changeset/152394> All reviewed patches have been landed. Closing bug. |