Bug 118372

Summary: Simplify PageThrottler ownership.
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: WebCore Misc.Assignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal CC: eflews.bot, gyuyoung.kim, webkit-ews
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fix
barraclough: review+, webkit-ews: commit-queue-
qt fix barraclough: review+

Gavin Barraclough
Reported 2013-07-03 16:33:22 PDT
PageThrottler is currently ref counted, but it's lifetime is actually tied to Page – should just be an owned relationship.
Attachments
Fix (4.29 KB, patch)
2013-07-03 16:41 PDT, Gavin Barraclough 		barraclough: review+
webkit-ews: commit-queue-
DetailsFormatted DiffDiff
qt fix (4.31 KB, patch)
2013-07-03 16:54 PDT, Gavin Barraclough 		barraclough: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2013-07-03 16:41:23 PDT
Created attachment 206034 [details] Fix
Early Warning System Bot
Comment 2 2013-07-03 16:50:11 PDT
Comment on attachment 206034 [details] Fix Attachment 206034 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1024206
EFL EWS Bot
Comment 3 2013-07-03 16:51:11 PDT
Comment on attachment 206034 [details] Fix Attachment 206034 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/1024208
Early Warning System Bot
Comment 4 2013-07-03 16:52:36 PDT
Comment on attachment 206034 [details] Fix Attachment 206034 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1015848
Gavin Barraclough
Comment 5 2013-07-03 16:54:14 PDT
Created attachment 206036 [details] qt fix
Gavin Barraclough
Comment 6 2013-07-03 16:56:08 PDT
Comment on attachment 206036 [details] qt fix r+ from Sam
Gavin Barraclough
Comment 7 2013-07-03 17:03:59 PDT
Committed revision 152384.
Note You need to log in before you can comment on or make changes to this bug.