Summary: | [EFL] DumpRenderTree doesn't run if "opengl_x11" engine is not available. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Viatcheslav Ostapenko <ostap73> | ||||||||
Component: | WebKit EFL | Assignee: | Viatcheslav Ostapenko <ostap73> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | cdumez, commit-queue, gyuyoung.kim, lucas.de.marchi, rakuco | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Viatcheslav Ostapenko
2013-07-03 13:32:40 PDT
Created attachment 206021 [details]
Patch
Created attachment 206024 [details]
Patch
Comment on attachment 206024 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=206024&action=review > Tools/DumpRenderTree/efl/DumpRenderTree.cpp:438 > const char* engine = 0; The engine here can be moved inside the #ifdef. Comment on attachment 206024 [details]
Patch
Please fix the nit before landing.
Comment on attachment 206024 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=206024&action=review >> Tools/DumpRenderTree/efl/DumpRenderTree.cpp:438 >> const char* engine = 0; > > The engine here can be moved inside the #ifdef. We actually don't even need this variable. We can simply pass ""opengl_x11" to ecore_evas_new(). Created attachment 206123 [details]
Patch for landing
Comment on attachment 206123 [details] Patch for landing Clearing flags on attachment: 206123 Committed r152408: <http://trac.webkit.org/changeset/152408> All reviewed patches have been landed. Closing bug. |