| Summary: | Nix upstreaming - Adding Nix render theme files | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Marcelo Lira <marcelo.lira> | ||||||
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cmarcelo, commit-queue, dino, d-r, eric.carlson, glenn, hugo.lima, japhet, jer.noble, luciano.wolf, luiz, nick.diego, sergio, tullio.lucena | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 117658, 118367 | ||||||||
| Attachments: |
|
||||||||
|
Description
Marcelo Lira
2013-07-03 12:57:28 PDT
Created attachment 206025 [details]
Patch
Comment on attachment 206025 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=206025&action=review Use real name: o-> renderObject. i->info|paintInfo. > Source/WebCore/platform/nix/RenderThemeNix.cpp:276 > +void RenderThemeNix::adjustProgressBarStyle(StyleResolver*, RenderStyle* style, Element *) const Element * -> Element* > Source/WebCore/platform/nix/RenderThemeNix.h:33 > +class RenderThemeNix : public RenderTheme { Plenty of missing OVERRIDE. > Source/WebCore/platform/nix/ScrollbarThemeNix.cpp:29 > +#include "NotImplemented.h" Why? > Source/WebCore/platform/nix/ScrollbarThemeNix.cpp:30 > +#include <stdio.h> Why? > Source/WebCore/platform/nix/ScrollbarThemeNix.cpp:46 > + return 0; // we paint on top Fix the comment. > Source/WebCore/platform/nix/ScrollbarThemeNix.h:33 > +class ScrollbarThemeNix : public ScrollbarTheme { Missing OVERRIDEs. Created attachment 206171 [details]
Patch
Thanks for the review. I have updated the patch. Could you give a cq+? Comment on attachment 206171 [details] Patch Clearing flags on attachment: 206171 Committed r152428: <http://trac.webkit.org/changeset/152428> All reviewed patches have been landed. Closing bug. |