Bug 118350

Summary:

Gif: zero filling should use memset instead of setRGBA for every pixel

Product:

WebKit

Reporter:

Balazs Kelemen <kbalazs>

Component:

Images

Assignee:

Balazs Kelemen <kbalazs>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

allan.jensen, commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Balazs Kelemen

Reported 2013-07-03 03:45:32 PDT

GIFImageDecoder::initializeFrameBuffer use a loop to fill a subrect with tranparent pixels. This is extremely ineffecient. The use case for this code path is not frequent on the web but it's still better to fix.

Attachments
Patch (7.48 KB, patch) 2013-07-03 04:46 PDT, Balazs Kelemen	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Balazs Kelemen

Comment 1 2013-07-03 04:46:46 PDT

Created attachment 205993 [details] Patch

WebKit Commit Bot

Comment 2 2013-07-03 06:55:30 PDT

Comment on attachment 205993 [details] Patch Clearing flags on attachment: 205993 Committed r152352: <http://trac.webkit.org/changeset/152352>

WebKit Commit Bot

Comment 3 2013-07-03 06:55:31 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.