Bug 118339

Summary: fourthTier: DFG should refer to BasicBlocks by BasicBlock* and not BlockIndex
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 118340    
Bug Blocks: 118338    
Attachments:
Description Flags
work in progress
none
more
none
more
none
moar!!
none
almost done, I think
none
it compiles
none
it runs programs
none
the patch msaboff: review+

Filip Pizlo
Reported 2013-07-02 21:58:34 PDT
More fun.
Attachments
work in progress (49.92 KB, patch)
2013-07-03 19:11 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
more (75.77 KB, patch)
2013-07-03 19:58 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
more (85.53 KB, patch)
2013-07-03 22:22 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
moar!! (121.51 KB, patch)
2013-07-04 09:20 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
almost done, I think (139.15 KB, patch)
2013-07-04 09:36 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
it compiles (161.37 KB, patch)
2013-07-04 12:01 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
it runs programs (162.39 KB, patch)
2013-07-04 12:15 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (162.40 KB, patch)
2013-07-04 13:58 PDT, Filip Pizlo 		msaboff: review+
DetailsFormatted DiffDiff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2013-07-03 19:11:15 PDT
Created attachment 206043 [details] work in progress
Filip Pizlo
Comment 2 2013-07-03 19:58:47 PDT
Created attachment 206048 [details] more
Filip Pizlo
Comment 3 2013-07-03 22:22:46 PDT
Created attachment 206050 [details] more
Filip Pizlo
Comment 4 2013-07-04 09:20:34 PDT
Created attachment 206097 [details] moar!!
Filip Pizlo
Comment 5 2013-07-04 09:36:32 PDT
Created attachment 206098 [details] almost done, I think
Filip Pizlo
Comment 6 2013-07-04 12:01:31 PDT
Created attachment 206108 [details] it compiles
Filip Pizlo
Comment 7 2013-07-04 12:15:08 PDT
Created attachment 206110 [details] it runs programs
Filip Pizlo
Comment 8 2013-07-04 13:58:08 PDT
Created attachment 206112 [details] the patch No performance regression.
Michael Saboff
Comment 9 2013-07-05 16:03:03 PDT
Comment on attachment 206112 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=206112&action=review > Source/JavaScriptCore/dfg/DFGDominators.h:53 > + } Add an empty line between methods.
Filip Pizlo
Comment 10 2013-07-05 18:02:04 PDT
Landed in http://trac.webkit.org/changeset/152431
Note You need to log in before you can comment on or make changes to this bug.