Bug 118339

Summary: fourthTier: DFG should refer to BasicBlocks by BasicBlock* and not BlockIndex
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 118340    
Bug Blocks: 118338    
Attachments:
Description Flags
work in progress
none
more
none
more
none
moar!!
none
almost done, I think
none
it compiles
none
it runs programs
none
the patch msaboff: review+

Description Filip Pizlo 2013-07-02 21:58:34 PDT 
More fun.
Comment 1 Filip Pizlo 2013-07-03 19:11:15 PDT 
Created attachment 206043 [details]
work in progress
Comment 2 Filip Pizlo 2013-07-03 19:58:47 PDT 
Created attachment 206048 [details]
more
Comment 3 Filip Pizlo 2013-07-03 22:22:46 PDT 
Created attachment 206050 [details]
more
Comment 4 Filip Pizlo 2013-07-04 09:20:34 PDT 
Created attachment 206097 [details]
moar!!
Comment 5 Filip Pizlo 2013-07-04 09:36:32 PDT 
Created attachment 206098 [details]
almost done, I think
Comment 6 Filip Pizlo 2013-07-04 12:01:31 PDT 
Created attachment 206108 [details]
it compiles
Comment 7 Filip Pizlo 2013-07-04 12:15:08 PDT 
Created attachment 206110 [details]
it runs programs
Comment 8 Filip Pizlo 2013-07-04 13:58:08 PDT 
Created attachment 206112 [details]
the patch

No performance regression.
Comment 9 Michael Saboff 2013-07-05 16:03:03 PDT 
Comment on attachment 206112 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=206112&action=review

> Source/JavaScriptCore/dfg/DFGDominators.h:53
> +    }

Add an empty line between methods.
Comment 10 Filip Pizlo 2013-07-05 18:02:04 PDT 
Landed in http://trac.webkit.org/changeset/152431