Bug 118337

Summary: Don't set z-index: 0 on lots of elements with -webkit-overflow-scrolling: touch
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Severity: Normal CC: allan.jensen, benjamin, commit-queue, dbates, esprehn+autocc, glenn, jeffrey+webkit, macpherson, menard, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch benjamin: review+

Description Simon Fraser (smfr) 2013-07-02 19:48:59 PDT
Don't set z-index: 0 on lots of elements with -webkit-overflow-scrolling: touch
Comment 1 Simon Fraser (smfr) 2013-07-02 19:57:09 PDT
Created attachment 205964 [details]
Comment 2 Benjamin Poulain 2013-07-02 20:01:56 PDT
Comment on attachment 205964 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=205964&action=review

> Source/WebCore/css/StyleResolver.cpp:1534
> +    if ((isScrollableOverflow(style->overflowX()) || isScrollableOverflow(style->overflowY())) && style->useTouchOverflowScrolling())

Can you move style->useTouchOverflowScrolling() to be the first condition? (for readability).
Comment 3 Simon Fraser (smfr) 2013-07-02 20:22:24 PDT
Comment 4 Daniel Bates 2013-07-24 14:53:07 PDT
(In reply to comment #3)
> http://trac.webkit.org/changeset/152335

This regressed both the rendering and the ability to scroll on <http://www.apple.com/mac-pro/index1.html>. See bug #119066 for more details.