Bug 118325

Summary: EGL and GLES files need to be included in Windows build
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: WebGLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Minor CC: bfulgham, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
Patch none

Alex Christensen
Reported 2013-07-02 14:39:43 PDT
Windows builds of WebGL need EGL symbols from GLContextEGL.cpp. Also, GraphicsContext3DOpenGL.cpp should be removed in favor of GraphicsContext3DOpenGLES.cpp to use with ANGLE's GLES implementation.
Attachments
Patch (5.52 KB, patch)
2013-07-02 14:42 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2013-07-02 14:42:26 PDT
Created attachment 205944 [details] Patch
Brent Fulgham
Comment 2 2013-07-02 16:56:32 PDT
Comment on attachment 205944 [details] Patch I was going to ask if we needed to exclude the GLContextEGL.cpp file for now, but I see that it is protected by an USE(EGL) guard in the cpp file. r=me.
WebKit Commit Bot
Comment 3 2013-07-02 17:19:22 PDT
Comment on attachment 205944 [details] Patch Clearing flags on attachment: 205944 Committed r152329: <http://trac.webkit.org/changeset/152329>
WebKit Commit Bot
Comment 4 2013-07-02 17:19:24 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.