Bug 118316

Summary: Replace RELEASE_ASSERT with ASSERT in CodeBlock:: bytecodeOffsetForCallAtIndex
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch ggaren: review+

Mark Hahnenberg
Reported 2013-07-02 12:06:19 PDT
This is causing some crashiness in release builds. We should replace it with an ASSERT until we track down all the places that need fixing in bug 118315.
Attachments
Patch (1.73 KB, patch)
2013-07-02 12:13 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Patch (1.73 KB, patch)
2013-07-02 12:23 PDT, Mark Hahnenberg 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2013-07-02 12:10:11 PDT
<rdar://problem/14165332>
Mark Hahnenberg
Comment 2 2013-07-02 12:13:43 PDT
Created attachment 205935 [details] Patch
Geoffrey Garen
Comment 3 2013-07-02 12:15:44 PDT
Comment on attachment 205935 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205935&action=review > Source/JavaScriptCore/bytecode/CodeBlock.h:228 > + ASSERT(index < m_rareData->m_callReturnIndexVector.size()); > + if (index < m_rareData->m_callReturnIndexVector.size()) I think you have this backwards?
Mark Hahnenberg
Comment 4 2013-07-02 12:21:40 PDT
(In reply to comment #3) > (From update of attachment 205935 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=205935&action=review > > > Source/JavaScriptCore/bytecode/CodeBlock.h:228 > > + ASSERT(index < m_rareData->m_callReturnIndexVector.size()); > > + if (index < m_rareData->m_callReturnIndexVector.size()) > > I think you have this backwards? :-(
Mark Hahnenberg
Comment 5 2013-07-02 12:23:23 PDT
Created attachment 205936 [details] Patch
Geoffrey Garen
Comment 6 2013-07-02 12:30:56 PDT
Comment on attachment 205936 [details] Patch r=me!
Mark Hahnenberg
Comment 7 2013-07-02 12:48:43 PDT
Committed r152314: <http://trac.webkit.org/changeset/152314>
Note You need to log in before you can comment on or make changes to this bug.