Bug 118316

Summary:

Replace RELEASE_ASSERT with ASSERT in CodeBlock:: bytecodeOffsetForCallAtIndex

Product:

WebKit

Reporter:

Mark Hahnenberg <mhahnenberg>

Component:

JavaScriptCore

Assignee:

Mark Hahnenberg <mhahnenberg>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	ggaren: review+

Description Mark Hahnenberg 2013-07-02 12:06:19 PDT

This is causing some crashiness in release builds. We should replace it with an ASSERT until we track down all the places that need fixing in bug 118315.

Comment 1 Mark Hahnenberg 2013-07-02 12:10:11 PDT

<rdar://problem/14165332>

Comment 2 Mark Hahnenberg 2013-07-02 12:13:43 PDT

Created attachment 205935 [details]
Patch

Comment 3 Geoffrey Garen 2013-07-02 12:15:44 PDT

Comment on attachment 205935 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205935&action=review

> Source/JavaScriptCore/bytecode/CodeBlock.h:228
> +        ASSERT(index < m_rareData->m_callReturnIndexVector.size());
> +        if (index < m_rareData->m_callReturnIndexVector.size())

I think you have this backwards?

Comment 4 Mark Hahnenberg 2013-07-02 12:21:40 PDT

(In reply to comment #3)
> (From update of attachment 205935 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=205935&action=review
> 
> > Source/JavaScriptCore/bytecode/CodeBlock.h:228
> > +        ASSERT(index < m_rareData->m_callReturnIndexVector.size());
> > +        if (index < m_rareData->m_callReturnIndexVector.size())
> 
> I think you have this backwards?

:-(

Comment 5 Mark Hahnenberg 2013-07-02 12:23:23 PDT

Created attachment 205936 [details]
Patch

Comment 6 Geoffrey Garen 2013-07-02 12:30:56 PDT

Comment on attachment 205936 [details]
Patch

r=me!

Comment 7 Mark Hahnenberg 2013-07-02 12:48:43 PDT

Committed r152314: <http://trac.webkit.org/changeset/152314>