Bug 118312

Summary:

OpenGLShims doesn't have getProcAddress for Windows

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

WebGL

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Minor

CC:

commit-queue, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Windows 7

Attachments:

Description	Flags
Patch	none

Alex Christensen

Reported 2013-07-02 11:36:37 PDT

OpenGLShims.cpp has a getProcAddress function used for filling a function table with function pointers to OpenGL functions. This function is implemented for Qt and it assumes everything else uses unix commands like dlsym. I added a Windows implementation that uses the WinAPI to do the same thing. I stepped through it in the debugger, and this succeeds in filling the function table with valid function pointers when linking with ANGLE libraries (of which libGLESv2 is one).

Attachments
Patch (1.34 KB, patch) 2013-07-02 11:38 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Alex Christensen

Comment 1 2013-07-02 11:38:15 PDT

Created attachment 205931 [details] Patch

Brent Fulgham

Comment 2 2013-07-02 14:22:54 PDT

Comment on attachment 205931 [details] Patch r=me

WebKit Commit Bot

Comment 3 2013-07-02 15:19:21 PDT

Comment on attachment 205931 [details] Patch Clearing flags on attachment: 205931 Committed r152325: <http://trac.webkit.org/changeset/152325>

WebKit Commit Bot

Comment 4 2013-07-02 15:19:23 PDT

All reviewed patches have been landed. Closing bug.

Ryosuke Niwa

Comment 5 2013-07-02 22:20:07 PDT

It seems like this patch broke Windows builds: http://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/49992 http://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/68153

Note You need to log in before you can comment on or make changes to this bug.