Bug 118312

Summary: OpenGLShims doesn't have getProcAddress for Windows
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: WebGLAssignee: Nobody <webkit-unassigned>
Severity: Minor CC: commit-queue, rniwa
Priority: P4    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Description Flags
Patch none

Description Alex Christensen 2013-07-02 11:36:37 PDT
OpenGLShims.cpp has a getProcAddress function used for filling a function table with function pointers to OpenGL functions.  This function is implemented for Qt and it assumes everything else uses unix commands like dlsym.  I added a Windows implementation that uses the WinAPI to do the same thing.  I stepped through it in the debugger, and this succeeds in filling the function table with valid function pointers when linking with ANGLE libraries (of which libGLESv2 is one).
Comment 1 Alex Christensen 2013-07-02 11:38:15 PDT
Created attachment 205931 [details]
Comment 2 Brent Fulgham 2013-07-02 14:22:54 PDT
Comment on attachment 205931 [details]

Comment 3 WebKit Commit Bot 2013-07-02 15:19:21 PDT
Comment on attachment 205931 [details]

Clearing flags on attachment: 205931

Committed r152325: <http://trac.webkit.org/changeset/152325>
Comment 4 WebKit Commit Bot 2013-07-02 15:19:23 PDT
All reviewed patches have been landed.  Closing bug.