Summary: | Modernize QualifiedName by wrapping gNameCache in a function and using more early exits | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||
Component: | WebKit Misc. | Assignee: | Ryosuke Niwa <rniwa> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | benjamin, commit-queue, esprehn+autocc, ggaren, kangil.han, kling, koivisto | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Ryosuke Niwa
2013-07-02 05:54:19 PDT
Created attachment 205898 [details]
Cleanup
Landed as https://trac.webkit.org/r152337. Comment on attachment 205898 [details] Cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=205898&action=review Man, you have a hard time vacationing :-D > Source/WebCore/dom/QualifiedName.cpp:124 > + result.append(prefix()); > + result.append(':'); > + result.append(localName()); > + return result.toString(); return prefix() + ':' + localName(); would be better here. Committed r152618: <http://trac.webkit.org/changeset/152618> |