Bug 118299

Summary: Modernize QualifiedName by wrapping gNameCache in a function and using more early exits
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: WebKit Misc.Assignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, esprehn+autocc, ggaren, kangil.han, kling, koivisto
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Cleanup kling: review+

Description Ryosuke Niwa 2013-07-02 05:54:19 PDT
It seems like QualifiedName.cpp hasn’t been updated in a while. Do some cleanups to match the modern coding style in WebKit.
Comment 1 Ryosuke Niwa 2013-07-02 05:58:12 PDT
Created attachment 205898 [details]
Cleanup
Comment 2 Ryosuke Niwa 2013-07-02 22:08:52 PDT
Landed as https://trac.webkit.org/r152337.
Comment 3 Benjamin Poulain 2013-07-02 23:20:32 PDT
Comment on attachment 205898 [details]
Cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=205898&action=review

Man, you have a hard time vacationing :-D

> Source/WebCore/dom/QualifiedName.cpp:124
> +    result.append(prefix());
> +    result.append(':');
> +    result.append(localName());
> +    return result.toString();

return prefix() + ':' + localName(); would be better here.
Comment 4 Ryosuke Niwa 2013-07-14 17:45:08 PDT
Committed r152618: <http://trac.webkit.org/changeset/152618>
Comment 5 Ryosuke Niwa 2013-07-14 18:30:26 PDT
Fixed Qt builds:
http://trac.webkit.org/changeset/152621
http://trac.webkit.org/changeset/152622