Bug 118299

Summary:

Modernize QualifiedName by wrapping gNameCache in a function and using more early exits

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

WebKit Misc.

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, commit-queue, esprehn+autocc, ggaren, kangil.han, kling, koivisto

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Cleanup	kling: review+

Ryosuke Niwa

Reported 2013-07-02 05:54:19 PDT

It seems like QualifiedName.cpp hasn’t been updated in a while. Do some cleanups to match the modern coding style in WebKit.

Attachments
Cleanup (3.43 KB, patch) 2013-07-02 05:58 PDT, Ryosuke Niwa	kling: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Ryosuke Niwa

Comment 1 2013-07-02 05:58:12 PDT

Created attachment 205898 [details] Cleanup

Ryosuke Niwa

Comment 2 2013-07-02 22:08:52 PDT

Landed as https://trac.webkit.org/r152337.

Benjamin Poulain

Comment 3 2013-07-02 23:20:32 PDT

Comment on attachment 205898 [details] Cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=205898&action=review Man, you have a hard time vacationing :-D > Source/WebCore/dom/QualifiedName.cpp:124 > + result.append(prefix()); > + result.append(':'); > + result.append(localName()); > + return result.toString(); return prefix() + ':' + localName(); would be better here.

Ryosuke Niwa

Comment 4 2013-07-14 17:45:08 PDT

Committed r152618: <http://trac.webkit.org/changeset/152618>

Ryosuke Niwa

Comment 5 2013-07-14 18:30:26 PDT

Fixed Qt builds: http://trac.webkit.org/changeset/152621 http://trac.webkit.org/changeset/152622

Note You need to log in before you can comment on or make changes to this bug.