| Summary: | Make KURL::hasPath private | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||||||
| Component: | New Bugs | Assignee: | Zan Dobersek <zan> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | cdumez, eflews.bot, gyuyoung.kim, philn, xan.lopez | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Zan Dobersek
2013-07-01 22:22:50 PDT
Created attachment 205864 [details]
Patch
Comment on attachment 205864 [details] Patch Attachment 205864 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1017200 Created attachment 205869 [details]
Patch
Comment on attachment 205869 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205869&action=review > Source/WebCore/platform/KURL.cpp:-559 > - if (!hasPath()) Why do we want to remove hasPath()? I find it is much more readable than comparing positions. Comment on attachment 205869 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205869&action=review > Source/WebCore/ChangeLog:9 > + Remove the KURL::hasPath method. It was not used anywhere but KURL::lastPathComponent where > + it's replaced by comparing positions of the ends of the port and path components. This seems like a good rationale to make hasPath private instead of public, but possibly not sufficient reason to remove it entirely. OK, I'll make the method private. Created attachment 207353 [details]
Patch
Comment on attachment 207353 [details]
Patch
The three sentence comment for this private function used in just one or two places seems like overkill.
Committed r153093: <http://trac.webkit.org/changeset/153093> Removed the comments prior to landing. |