Bug 118262

Summary:

DrawingBuffer constructor and destructor not defined for Windows

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

WebGL

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Trivial

CC:

commit-queue, dino, d-r

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Description Alex Christensen 2013-07-01 14:02:00 PDT

The DrawingBuffer constructors and destructors for Cairo, Qt, and Mac are almost identical.  I assume non-Cairo Windows should do the same thing.  I'm not sure because Clutter and BlackBerry have significant differences from the other ports' constructors and destructors.

The Mac constructor has Objective C calls inside it, so it can't easily be refactored to a C++ file, but the Cairo and Qt constructors can be combined.

Comment 1 Alex Christensen 2013-07-01 14:09:16 PDT

Created attachment 205834 [details]
Patch

Comment 2 WebKit Commit Bot 2013-07-01 16:21:55 PDT

Comment on attachment 205834 [details]
Patch

Clearing flags on attachment: 205834

Committed r152269: <http://trac.webkit.org/changeset/152269>

Comment 3 WebKit Commit Bot 2013-07-01 16:21:57 PDT

All reviewed patches have been landed.  Closing bug.