Bug 118262 - DrawingBuffer constructor and destructor not defined for Windows
Summary: DrawingBuffer constructor and destructor not defined for Windows
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Trivial
Assignee: Nobody
Depends on:
Reported: 2013-07-01 14:02 PDT by Alex Christensen
Modified: 2013-07-01 16:21 PDT (History)
3 users (show)

See Also:

Patch (8.31 KB, patch)
2013-07-01 14:09 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2013-07-01 14:02:00 PDT
The DrawingBuffer constructors and destructors for Cairo, Qt, and Mac are almost identical.  I assume non-Cairo Windows should do the same thing.  I'm not sure because Clutter and BlackBerry have significant differences from the other ports' constructors and destructors.

The Mac constructor has Objective C calls inside it, so it can't easily be refactored to a C++ file, but the Cairo and Qt constructors can be combined.
Comment 1 Alex Christensen 2013-07-01 14:09:16 PDT
Created attachment 205834 [details]
Comment 2 WebKit Commit Bot 2013-07-01 16:21:55 PDT
Comment on attachment 205834 [details]

Clearing flags on attachment: 205834

Committed r152269: <http://trac.webkit.org/changeset/152269>
Comment 3 WebKit Commit Bot 2013-07-01 16:21:57 PDT
All reviewed patches have been landed.  Closing bug.