Bug 118244

Summary: [Qt] Avoid creating a QWindow for offscreen GraphicsContext3D
Product: WebKit Reporter: Allan Sandfeld Jensen <allan.jensen>
Component: WebGLAssignee: Allan Sandfeld Jensen <allan.jensen>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, jturcotte, noam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Allan Sandfeld Jensen 2013-07-01 07:02:11 PDT
With Qt 5.0 we had to create a QWindow inorder to make a QOpenGLContext current. In Qt 5.1 we have the option of using a QOffscreenSurface instead. On platforms like X11 the results will be the same, but on OpenGL based platforms the QOffscreenSurface will use a pbuffer.
Comment 1 Allan Sandfeld Jensen 2013-07-01 07:05:20 PDT
Created attachment 205809 [details]
Patch
Comment 2 Noam Rosenthal 2013-07-01 07:17:06 PDT
Comment on attachment 205809 [details]
Patch

Nice!
Comment 3 Allan Sandfeld Jensen 2013-07-01 07:30:03 PDT
Comment on attachment 205809 [details]
Patch

Clearing flags on attachment: 205809

Committed r152222: <http://trac.webkit.org/changeset/152222>
Comment 4 Allan Sandfeld Jensen 2013-07-01 07:30:08 PDT
All reviewed patches have been landed.  Closing bug.