Bug 118218

Summary: Avoid calling isSimpleContainerCompositingLayer() an extra time
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, esprehn+autocc, glenn, noam, simon.fraser, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Simon Fraser (smfr)
Reported 2013-06-29 12:47:48 PDT
Avoid calling isSimpleContainerCompositingLayer() an extra time
Attachments
Patch (3.28 KB, patch)
2013-06-29 12:48 PDT, Simon Fraser (smfr) 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2013-06-29 12:48:59 PDT
Created attachment 205772 [details] Patch
Tim Horton
Comment 2 2013-06-29 12:56:14 PDT
Comment on attachment 205772 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205772&action=review > Source/WebCore/rendering/RenderLayerBacking.cpp:982 > + bool hasPaintedContent = containsPaintedContent(isSimpleContainer); Wait, do you even need to pass it in? In the previous case, you were not calling in ever if it was false, so you can assume it's true? And, before, you were avoiding the function call at all...
Simon Fraser (smfr)
Comment 3 2013-06-29 13:23:22 PDT
https://trac.webkit.org/r152213
Note You need to log in before you can comment on or make changes to this bug.