Bug 118218

Summary:

Avoid calling isSimpleContainerCompositingLayer() an extra time

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

New Bugs

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, commit-queue, esprehn+autocc, glenn, noam, simon.fraser, thorton

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	thorton: review+

Description Simon Fraser (smfr) 2013-06-29 12:47:48 PDT

Avoid calling isSimpleContainerCompositingLayer() an extra time

Comment 1 Simon Fraser (smfr) 2013-06-29 12:48:59 PDT

Created attachment 205772 [details]
Patch

Comment 2 Tim Horton 2013-06-29 12:56:14 PDT

Comment on attachment 205772 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205772&action=review

> Source/WebCore/rendering/RenderLayerBacking.cpp:982
> +    bool hasPaintedContent = containsPaintedContent(isSimpleContainer);

Wait, do you even need to pass it in? In the previous case, you were not calling in ever if it was false, so you can assume it's true? And, before, you were avoiding the function call at all...

Comment 3 Simon Fraser (smfr) 2013-06-29 13:23:22 PDT

https://trac.webkit.org/r152213