Bug 118210

Summary: PageThrottler::shouldThrottleTimers is wrong.
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: WebCore Misc.Assignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, jberlin, kling, sam, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fix andersca: review+

Gavin Barraclough
Reported 2013-06-28 18:20:53 PDT
m_throttleState == PageNotThrottledState -> page NOT throttled, so should NOT throttle timers m_throttleState != PageNotThrottledState -> page NOT NOT throttled, so should throttle timers This needs cleaning up, but for now, 1 character fix.
Attachments
Fix (1.58 KB, patch)
2013-06-28 18:31 PDT, Gavin Barraclough 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2013-06-28 18:31:59 PDT
Created attachment 205760 [details] Fix Fixes <rdar://problem/14247819>
Gavin Barraclough
Comment 2 2013-06-28 18:45:50 PDT
Committed revision 152202.
Andreas Kling
Comment 3 2013-06-28 22:56:04 PDT
This change broke fast/dom/timer-throttling-hidden-page.html on Mac: http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK1%20(Tests)/r152202%20(11080)/results.html
Note You need to log in before you can comment on or make changes to this bug.