Bug 118206

Summary: Cached pages don't update their backing scale factor when it changes
Product: WebKit Reporter: Beth Dakin <bdakin>
Component: Layout and RenderingAssignee: Beth Dakin <bdakin>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, dino, sam, simon.fraser, thorton
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Description Beth Dakin 2013-06-28 15:07:52 PDT
Steps to reproduce:
1. Go to daringfireball.net on non-HiDPI display.
2. Click on any link on the page e.g. "Projects".
3. Move the window to HiDPI display.
4. Click the back button.

<rdar://problem/14261627>
Comment 1 Beth Dakin 2013-06-28 15:44:24 PDT
Created attachment 205750 [details]
Patch
Comment 2 Tim Horton 2013-06-28 15:57:46 PDT
Comment on attachment 205750 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205750&action=review

> Source/WebCore/history/CachedPage.h:74
> +    bool m_needsDeviceScaleChanged;

I don't really like the "needs XYZ changed" naming (it's really 'needs to *call* XYZChanged', or maybe needsDeviceScaleUpdate or something), but there's already one like that here :|
Comment 3 Beth Dakin 2013-06-28 16:13:02 PDT
Thanks, Tim! I gave it some thought but was unable to think of a better name. I do agree it's not great. I will keep thinking on it.