Bug 118200

Summary: more webgl files need to be included in Windows build
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: WebGLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Minor CC: bfulgham, commit-queue, dino, d-r, gtk-ews, philn, xan.lopez
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Alex Christensen
Reported 2013-06-28 11:59:54 PDT
There are more graphics source files that need to be included in the Visual Studio projects, more headers that can't be found and don't need to be found, etc.
Attachments
Patch (9.86 KB, patch)
2013-06-28 12:11 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (9.87 KB, patch)
2013-06-28 13:04 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (10.69 KB, patch)
2013-06-28 13:37 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2013-06-28 12:11:27 PDT
Created attachment 205731 [details] Patch
kov's GTK+ EWS bot
Comment 2 2013-06-28 12:22:49 PDT
Comment on attachment 205731 [details] Patch Attachment 205731 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/987467
Alex Christensen
Comment 3 2013-06-28 13:04:52 PDT
Created attachment 205735 [details] Patch
Brent Fulgham
Comment 4 2013-06-28 13:22:11 PDT
Comment on attachment 205735 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205735&action=review > Source/WebCore/WebCore.vcxproj/WebCore.vcxproj:-4367 > - <ClCompile Include="..\platform\graphics\opengl\GraphicsContext3DOpenGLES.cpp" /> Don't we want to use OpenGLES? I thought ANGLE provided a full GLES implementation? > Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters:-7035 > - </ClCompile> Ditto: I thought we were targeting OpenGL ES because of ANGLE?
Alex Christensen
Comment 5 2013-06-28 13:37:43 PDT
Created attachment 205738 [details] Patch
Brent Fulgham
Comment 6 2013-06-28 13:45:46 PDT
Comment on attachment 205738 [details] Patch r=me.
WebKit Commit Bot
Comment 7 2013-06-28 15:44:11 PDT
Comment on attachment 205738 [details] Patch Clearing flags on attachment: 205738 Committed r152192: <http://trac.webkit.org/changeset/152192>
WebKit Commit Bot
Comment 8 2013-06-28 15:44:13 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.