| Summary: | media/video-currentTime.html flakey | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||
| Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, eric.carlson, glenn, jberlin, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Jer Noble
2013-06-28 11:34:57 PDT
Created attachment 205729 [details]
Patch
Comment on attachment 205729 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205729&action=review > LayoutTests/media/video-currentTime-expected.txt:5 > +video.currentTime > 0 OK Nit: is there any reason the test results need to change (eg. call testExpected("video.currentTime", 0, '>') rather than logResult(true, 'video.currentTime > 0') ? Comment on attachment 205729 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205729&action=review >> LayoutTests/media/video-currentTime-expected.txt:5 >> +video.currentTime > 0 OK > > Nit: is there any reason the test results need to change (eg. call testExpected("video.currentTime", 0, '>') rather than logResult(true, 'video.currentTime > 0') ? Yes, because the first timeupdate event will likely always be at currentTime == 0. Comment on attachment 205729 [details] Patch Clearing flags on attachment: 205729 Committed r152184: <http://trac.webkit.org/changeset/152184> All reviewed patches have been landed. Closing bug. |