Summary: | Update TestExpectations so new Shapes tests are skipped where the old ones were | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Bem Jones-Bey <bjonesbe> | ||||||
Component: | New Bugs | Assignee: | Bem Jones-Bey <bjonesbe> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cdumez, commit-queue, gyuyoung.kim, paroga, rakuco, roger_fong | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Bem Jones-Bey
2013-06-28 07:54:27 PDT
Created attachment 205714 [details]
Patch
Update expectations so that the new tests are skipped on platforms the old tests were skipped on.
Comment on attachment 205714 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205714&action=review > LayoutTests/platform/efl/TestExpectations:341 > +webkit.org/b/83898 csswg/submitted/shapes Those tests are passing on EFL port. SHAPES are probably enabled for us because it is enabled for all port in Tools/Scripts/webkitperl/FeatureList.pm. I ran a couple of these tests manually in MiniBrowser and they run fine. (In reply to comment #2) > (From update of attachment 205714 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=205714&action=review > > > LayoutTests/platform/efl/TestExpectations:341 > > +webkit.org/b/83898 csswg/submitted/shapes > > Those tests are passing on EFL port. SHAPES are probably enabled for us because it is enabled for all port in Tools/Scripts/webkitperl/FeatureList.pm. I ran a couple of these tests manually in MiniBrowser and they run fine. That's great news. I'll remove the expectations for EFL completely and upload a new patch. Created attachment 205716 [details]
Patch
Remove shapes skipping for EFL since it is apparently enabled now.
Comment on attachment 205716 [details]
Patch
I cannot speak for the windows part but the EFL changes look good to me.
Comment on attachment 205716 [details]
Patch
r=me.
Comment on attachment 205716 [details] Patch Clearing flags on attachment: 205716 Committed r152180: <http://trac.webkit.org/changeset/152180> All reviewed patches have been landed. Closing bug. |