Bug 118191

Summary:

Get rid of IsWorkerGlobalScope and ExtendsDOMGlobalObject extended attributes

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Bindings

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, darin, esprehn+autocc, haraken, laszlo.gombos, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Chris Dumez 2013-06-28 07:31:12 PDT

We should not need to specify the [IsWorkerGlobalScope] and [ExtendsDOMGlobalObject] extended attributes. The bindings generator should be smart enough to figure this out on its own.

Comment 1 Chris Dumez 2013-06-28 07:35:41 PDT

Created attachment 205713 [details]
Patch

Comment 2 Kentaro Hara 2013-06-28 07:39:36 PDT

Comment on attachment 205713 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205713&action=review

Looks like good refactoring.

> Source/WebCore/workers/WorkerGlobalScope.idl:31
>      JSCustomGetOwnPropertySlotAndDescriptor,

BTW, now JSC is the only engine in WebKIt, it wouldn't make sense to prefix JSC-specific IDL attributes with "JS".

Comment 3 WebKit Commit Bot 2013-06-28 09:02:09 PDT

Comment on attachment 205713 [details]
Patch

Clearing flags on attachment: 205713

Committed r152168: <http://trac.webkit.org/changeset/152168>

Comment 4 WebKit Commit Bot 2013-06-28 09:02:13 PDT

All reviewed patches have been landed.  Closing bug.

Comment 5 Zan Dobersek 2013-11-20 03:01:38 PST

*** Bug 77966 has been marked as a duplicate of this bug. ***