Bug 118191 - Get rid of IsWorkerGlobalScope and ExtendsDOMGlobalObject extended attributes
Summary: Get rid of IsWorkerGlobalScope and ExtendsDOMGlobalObject extended attributes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
: 77966 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-06-28 07:31 PDT by Chris Dumez
Modified: 2013-11-20 03:01 PST (History)
6 users (show)

See Also:

Attachments
Patch (12.74 KB, patch)
2013-06-28 07:35 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2013-06-28 07:31:12 PDT 
We should not need to specify the [IsWorkerGlobalScope] and [ExtendsDOMGlobalObject] extended attributes. The bindings generator should be smart enough to figure this out on its own.
Comment 1 Chris Dumez 2013-06-28 07:35:41 PDT 
Created attachment 205713 [details]
Patch
Comment 2 Kentaro Hara 2013-06-28 07:39:36 PDT 
Comment on attachment 205713 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205713&action=review

Looks like good refactoring.

> Source/WebCore/workers/WorkerGlobalScope.idl:31
>      JSCustomGetOwnPropertySlotAndDescriptor,

BTW, now JSC is the only engine in WebKIt, it wouldn't make sense to prefix JSC-specific IDL attributes with "JS".
Comment 3 WebKit Commit Bot 2013-06-28 09:02:09 PDT 
Comment on attachment 205713 [details]
Patch

Clearing flags on attachment: 205713

Committed r152168: <http://trac.webkit.org/changeset/152168>
Comment 4 WebKit Commit Bot 2013-06-28 09:02:13 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Zan Dobersek 2013-11-20 03:01:38 PST 
*** Bug 77966 has been marked as a duplicate of this bug. ***