WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
118191
Get rid of IsWorkerGlobalScope and ExtendsDOMGlobalObject extended attributes
https://bugs.webkit.org/show_bug.cgi?id=118191
Summary
Get rid of IsWorkerGlobalScope and ExtendsDOMGlobalObject extended attributes
Chris Dumez
Reported
2013-06-28 07:31:12 PDT
We should not need to specify the [IsWorkerGlobalScope] and [ExtendsDOMGlobalObject] extended attributes. The bindings generator should be smart enough to figure this out on its own.
Attachments
Patch
(12.74 KB, patch)
2013-06-28 07:35 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2013-06-28 07:35:41 PDT
Created
attachment 205713
[details]
Patch
Kentaro Hara
Comment 2
2013-06-28 07:39:36 PDT
Comment on
attachment 205713
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=205713&action=review
Looks like good refactoring.
> Source/WebCore/workers/WorkerGlobalScope.idl:31 > JSCustomGetOwnPropertySlotAndDescriptor,
BTW, now JSC is the only engine in WebKIt, it wouldn't make sense to prefix JSC-specific IDL attributes with "JS".
WebKit Commit Bot
Comment 3
2013-06-28 09:02:09 PDT
Comment on
attachment 205713
[details]
Patch Clearing flags on attachment: 205713 Committed
r152168
: <
http://trac.webkit.org/changeset/152168
>
WebKit Commit Bot
Comment 4
2013-06-28 09:02:13 PDT
All reviewed patches have been landed. Closing bug.
Zan Dobersek
Comment 5
2013-11-20 03:01:38 PST
***
Bug 77966
has been marked as a duplicate of this bug. ***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug