Bug 118187

Summary: accessibility/media-element.html does not support platforms without subroles
Product: WebKit Reporter: Mario Sanchez Prada <mario>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, buildbot, cfleizach, commit-queue, dmazzoni, eric.carlson, glenn, jcraig, jdiggs, jer.noble, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch proposal
cfleizach: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 none

Mario Sanchez Prada
Reported 2013-06-28 05:43:55 PDT
In revision r151852, the accessibility/media-element-pretty-diff.html test was expanded to also print subroles whenever available, but is always assuming that at least the "AXSubrole: " string will be returned when reading the .subrole property, which does not apply to platforms not supporting subroles, like ATK.
Attachments
Patch proposal (2.15 KB, patch)
2013-06-28 05:50 PDT, Mario Sanchez Prada 		cfleizach: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 (675.23 KB, application/zip)
2013-06-28 08:35 PDT, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Mario Sanchez Prada
Comment 1 2013-06-28 05:50:43 PDT
Created attachment 205706 [details] Patch proposal I believe this extra nullcheck would be enough to make the GTK bots happy again, without disturbing others
Build Bot
Comment 2 2013-06-28 08:35:30 PDT
Comment on attachment 205706 [details] Patch proposal Attachment 205706 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/976517 New failing tests: editing/pasteboard/5601583-1.html
Build Bot
Comment 3 2013-06-28 08:35:31 PDT
Created attachment 205717 [details] Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.3
Mario Sanchez Prada
Comment 4 2013-06-28 09:40:12 PDT
Committed r152172: <http://trac.webkit.org/changeset/152172>
Note You need to log in before you can comment on or make changes to this bug.