Bug 118186

Summary:

[Autotools] Properly quote harfbuzz-icu pkg-config check

Product:

WebKit

Reporter:

Sean Bright <sean>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Minor

CC:

cgarcia, commit-queue, gustavo, mrobinson, zan

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Linux

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Description Sean Bright 2013-06-28 05:12:48 PDT

A secondary test was added to check for harfbuzz-icu when it was split but the test wasn't properly quoted.  If the test fails you get an error about missing version "./configure.9.8" instead of the expected "0.9.8".

Comment 1 Sean Bright 2013-06-28 05:23:09 PDT

Created attachment 205701 [details]
Patch

Comment 2 Zan Dobersek 2013-06-28 05:29:26 PDT

The patch looks OK, but requires a ChangeLog entry.

The contributing documentation has some guidelines on how to prepare the ChangeLog.
http://www.webkit.org/coding/contributing.html

Comment 3 Sean Bright 2013-06-28 05:36:58 PDT

Created attachment 205703 [details]
Patch

Comment 4 Sean Bright 2013-06-28 05:39:06 PDT

(In reply to comment #2)
> The patch looks OK, but requires a ChangeLog entry.

Yes I had some issues with webkit-patch, so I manually created a diff with a ChangeLog entry and uploaded directly.

Comment 5 Carlos Garcia Campos 2013-06-28 05:41:11 PDT

Thanks for adding the changelog entry, but could you explain in the changelog what's the problem you are fixing? something similar to the first comment in this bug.

Comment 6 Sean Bright 2013-06-28 05:46:15 PDT

Created attachment 205705 [details]
Patch

Comment 7 Sean Bright 2013-06-28 05:47:38 PDT

(In reply to comment #5)
> but could you explain in the changelog what's the problem you are fixing?

I've included more detail in the most recent attachment.

Comment 8 Carlos Garcia Campos 2013-06-28 05:52:51 PDT

Comment on attachment 205705 [details]
Patch

Thanks! It seems there are more cases like this one in FindDependencies.m4 we should fix them also eventually.

Comment 9 WebKit Commit Bot 2013-06-28 06:32:24 PDT

Comment on attachment 205705 [details]
Patch

Clearing flags on attachment: 205705

Committed r152163: <http://trac.webkit.org/changeset/152163>

Comment 10 WebKit Commit Bot 2013-06-28 06:32:26 PDT

All reviewed patches have been landed.  Closing bug.