Bug 118177

Summary:

Use gtk_widget_get_preferred_size instead of deprecated gtk_widget_get_requisition

Product:

WebKit

Reporter:

Iago Toral <itoral>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Trivial

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch	none

Iago Toral

Reported 2013-06-28 02:38:11 PDT

Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp uses deprecated function gtk_widget_get_requisition, which produces compilation warnings. I'll attach a patch shortly to use gtk_widget_get_preferred_size instead, which is the function used to implement gtk_widget_get_requisition in GTK.

Attachments
Proposed patch (1.33 KB, patch) 2013-06-28 02:41 PDT, Iago Toral	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Iago Toral

Comment 1 2013-06-28 02:41:51 PDT

Created attachment 205683 [details] Proposed patch

Carlos Garcia Campos

Comment 2 2013-06-28 02:52:15 PDT

Comment on attachment 205683 [details] Proposed patch Thanks!

WebKit Commit Bot

Comment 3 2013-06-28 04:00:15 PDT

Comment on attachment 205683 [details] Proposed patch Clearing flags on attachment: 205683 Committed r152159: <http://trac.webkit.org/changeset/152159>

WebKit Commit Bot

Comment 4 2013-06-28 04:00:17 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.