Bug 118173

Summary: [wk2] TiledCoreAnimationDrawingArea should support scrolling its exposed rect
Product: WebKit Reporter: Tim Horton <thorton>
Component: WebKit2Assignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
preliminary
none
patch andersca: review+

Tim Horton
Reported 2013-06-28 02:17:32 PDT
Currently we mandate that scrolling must be disabled if we're clipping to the WKView's visible/prepared-content rect, because TCADA doesn't know how to keep the exposed rect offset by the scroll position as it should. But, it can!
Attachments
preliminary (5.04 KB, patch)
2013-06-28 03:11 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
patch (7.27 KB, patch)
2013-06-28 16:30 PDT, Tim Horton 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2013-06-28 02:18:02 PDT
<rdar://problem/14301166>
Tim Horton
Comment 2 2013-06-28 03:11:51 PDT
Created attachment 205688 [details] preliminary
Tim Horton
Comment 3 2013-06-28 16:30:19 PDT
Created attachment 205755 [details] patch
Sam Weinig
Comment 4 2013-06-28 16:47:23 PDT
Comment on attachment 205755 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=205755&action=review > Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:441 > + for (PageOverlayLayerMap::iterator it = m_pageOverlayLayers.begin(), end = m_pageOverlayLayers.end(); it != end; ++it) > + if (TiledBacking* tiledBacking = it->value->tiledBacking()) > + tiledBacking->setExposedRect(m_scrolledExposedRect); Braces please.
Tim Horton
Comment 5 2013-06-28 16:57:52 PDT
Comment on attachment 205755 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=205755&action=review >> Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:441 >> + tiledBacking->setExposedRect(m_scrolledExposedRect); > > Braces please. Indeed.
Tim Horton
Comment 6 2013-07-01 14:48:43 PDT
http://trac.webkit.org/changeset/152266
Note You need to log in before you can comment on or make changes to this bug.