Bug 118169

Summary: REGRESSION(151586): multipart/x-mixed-replace images are broken
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Page LoadingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, cgarcia, commit-queue, japhet, thorton
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://158.250.33.102/view/view.htm
Bug Depends on:    
Bug Blocks: 115804    
Attachments:
Description Flags
Patch ap: review+

Alexey Proskuryakov
Reported 2013-06-27 22:11:42 PDT
<http://trac.webkit.org/changeset/151586> broke a lot of webcam sites, such as <http://158.250.33.102/view/view.htm>. <rdar://problem/14242032>
Attachments
Patch (1.81 KB, patch)
2013-06-28 03:17 PDT, Carlos Garcia Campos 		ap: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2013-06-28 01:04:36 PDT
It works for me, what's exactly broken?
Tim Horton
Comment 2 2013-06-28 01:45:48 PDT
I get corrupt and/or partial images in Safari.
Carlos Garcia Campos
Comment 3 2013-06-28 02:53:35 PDT
Actually it crashes for me in another laptop I've tried, I'm looking at it.
Tim Horton
Comment 4 2013-06-28 02:54:09 PDT
(In reply to comment #3) > Actually it crashes for me in another laptop I've tried, I'm looking at it. Yeah, I think we see that in some places too.
Carlos Garcia Campos
Comment 5 2013-06-28 03:17:38 PDT
Created attachment 205689 [details] Patch In case of multipart content we always have to copy the data, I removed that by mistake in r151586.
Chris Dumez
Comment 6 2013-06-28 03:56:10 PDT
Visiting http://158.250.33.102/view/view.htm also makes EFL wk1 and wk2 crash. Backtrace: http://pastebin.com/xLcPkHHg
Carlos Garcia Campos
Comment 7 2013-06-28 04:21:24 PDT
(In reply to comment #6) > Visiting http://158.250.33.102/view/view.htm also makes EFL wk1 and wk2 crash. > Backtrace: http://pastebin.com/xLcPkHHg Thanks for testing it, yes, same crash I got, the attached patch fixes the crash.
Alexey Proskuryakov
Comment 8 2013-06-28 09:44:35 PDT
Comment on attachment 205689 [details] Patch r=me to land just the fix to adddress the regression ASAP, however please consider making a regression test as a follow-up bug.
Carlos Garcia Campos
Comment 9 2013-06-29 00:24:36 PDT
(In reply to comment #8) > (From update of attachment 205689 [details]) > r=me to land just the fix to adddress the regression ASAP, however please consider making a regression test as a follow-up bug. Yes, I thought about it, but I didn't have time to understand how multipart layout tests work and how to write a new one (not that this was not easy to reproduce and had different effects to different people), so I submitted the patch without a test because it fixes a crash. I'll try to make a test next week.
Carlos Garcia Campos
Comment 10 2013-06-29 00:26:26 PDT
Committed r152207: <http://trac.webkit.org/changeset/152207>
Note You need to log in before you can comment on or make changes to this bug.