Summary: | Avoid duplicating hostWindow() call in ScrollView.cpp | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sanghyup Lee <sh53.lee> | ||||||||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | cdumez, commit-queue | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Sanghyup Lee
2013-06-27 22:06:46 PDT
Created attachment 205664 [details]
Patch
Comment on attachment 205664 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205664&action=review > Source/WebCore/ChangeLog:8 > + No new tests (OOPS!). Please read "ChangeLog files" in https://www.webkit.org/coding/contributing.html Created attachment 205667 [details]
Patch
Comment on attachment 205667 [details]
Patch
There are several other similar cases in ScrollView.cpp, why not fix them as well?
Created attachment 205675 [details]
Patch
(In reply to comment #4) > (From update of attachment 205667 [details]) > There are several other similar cases in ScrollView.cpp, why not fix them as well? OK. I had fixed it. Comment on attachment 205675 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205675&action=review Looks fine. r=me with nit. > Source/WebCore/ChangeLog:8 > + Remove a redundant call in ScrollView.cpp nit: "redundant hostWindow() calls". Created attachment 205687 [details]
Patch for landing
Comment on attachment 205687 [details] Patch for landing Clearing flags on attachment: 205687 Committed r152161: <http://trac.webkit.org/changeset/152161> All reviewed patches have been landed. Closing bug. |