Bug 118168

Summary: Avoid duplicating hostWindow() call in ScrollView.cpp
Product: WebKit Reporter: Sanghyup Lee <sh53.lee>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing none

Description Sanghyup Lee 2013-06-27 22:06:46 PDT
Patch follows.
Comment 1 Sanghyup Lee 2013-06-27 22:14:32 PDT
Created attachment 205664 [details]
Patch
Comment 2 Gyuyoung Kim 2013-06-27 22:19:13 PDT
Comment on attachment 205664 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205664&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests (OOPS!).

Please read "ChangeLog files" in https://www.webkit.org/coding/contributing.html
Comment 3 Sanghyup Lee 2013-06-27 22:56:56 PDT
Created attachment 205667 [details]
Patch
Comment 4 Chris Dumez 2013-06-27 23:55:08 PDT
Comment on attachment 205667 [details]
Patch

There are several other similar cases in ScrollView.cpp, why not fix them as well?
Comment 5 Sanghyup Lee 2013-06-28 00:43:35 PDT
Created attachment 205675 [details]
Patch
Comment 6 Sanghyup Lee 2013-06-28 02:25:33 PDT
(In reply to comment #4)
> (From update of attachment 205667 [details])
> There are several other similar cases in ScrollView.cpp, why not fix them as well?

OK. I had fixed it.
Comment 7 Chris Dumez 2013-06-28 02:41:43 PDT
Comment on attachment 205675 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205675&action=review

Looks fine. r=me with nit.

> Source/WebCore/ChangeLog:8
> +        Remove a redundant call in ScrollView.cpp

nit: "redundant hostWindow() calls".
Comment 8 Sanghyup Lee 2013-06-28 03:11:33 PDT
Created attachment 205687 [details]
Patch for landing
Comment 9 WebKit Commit Bot 2013-06-28 04:14:55 PDT
Comment on attachment 205687 [details]
Patch for landing

Clearing flags on attachment: 205687

Committed r152161: <http://trac.webkit.org/changeset/152161>
Comment 10 WebKit Commit Bot 2013-06-28 04:14:58 PDT
All reviewed patches have been landed.  Closing bug.