Bug 118148

Summary: fourthTier: JSC's disassembly infrastructure should be able to disassemble the code that LLVM generates
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 112840    
Attachments:
Description Flags
the patch andersca: review+

Filip Pizlo
Reported 2013-06-27 14:17:35 PDT
Oh boy. UDis86 cannot disassemble the AVX (or whatever it's called) stuff that LLVM generates for floating point. So the right decision is to switch to the LLVM disassembler, right? Wrong!! LLVM's disassembler cannot disassemble the load-from-absolute-address-into-%rax instructions that our JIT generates quite a lot of. So we should use a combination of the two disassemblers.
Attachments
the patch (44.18 KB, patch)
2013-06-27 14:23 PDT, Filip Pizlo 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2013-06-27 14:23:00 PDT
Created attachment 205635 [details] the patch
Filip Pizlo
Comment 2 2013-06-27 15:51:10 PDT
Landed in http://trac.webkit.org/changeset/152131
Note You need to log in before you can comment on or make changes to this bug.