Bug 118128

Summary: [webkitpy] AbstractPatchSequencingCommand should have _prepare_state
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dpranke, galpeter, glenn, jbadics, ossy, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 117831    
Attachments:
Description Flags
Patch none

Description Csaba Osztrogonác 2013-06-27 05:36:00 PDT 
AbstractSequencedCommand already has _prepare_state method to let 
its subclasses to prepare an initial state, set options, etc.
for example: queries.py/SuggestReviewers, download.py/Clean,Build,Land

Unfortunately AbstractPatchSequencingCommand doesn't have _prepare_state method
to do similar things, we can only use prepare_steps. But it's overkiller to
implement new steps for trivial things, like setting an option.

It is a dependency for the new run-tests-touched-by-attachment command,
see https://bugs.webkit.org/show_bug.cgi?id=117831#c3 for details.
Comment 1 Csaba Osztrogonác 2013-06-27 05:42:34 PDT 
Created attachment 205595 [details]
Patch
Comment 2 Peter Gal 2013-06-27 06:36:51 PDT 
View in context: https://bugs.webkit.org/attachment.cgi?id=205595&action=review

> Tools/ChangeLog:10
> +        (AbstractPatchSequencingCommand._prepare_to_process): Call _prepare_state before prepare_steps.

you mean prepare_sequence instead of the prepare_steps?
Comment 3 Ryosuke Niwa 2013-06-27 09:15:57 PDT 
Comment on attachment 205595 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205595&action=review

> Tools/ChangeLog:7
> +

You should probably mention that this is a preparation to fix some other bug.
Comment 4 Csaba Osztrogonác 2013-06-27 10:50:40 PDT 
Committed r152113: <http://trac.webkit.org/changeset/152113>