Bug 118128 – [webkitpy] AbstractPatchSequencingCommand should have _prepare_state

• Component: New Bugs
• Status: RESOLVED FIXED

[Csaba Osztrogonác]

AbstractSequencedCommand already has _prepare_state method to let 
its subclasses to prepare an initial state, set options, etc.
for example: queries.py/SuggestReviewers, download.py/Clean,Build,Land

Unfortunately AbstractPatchSequencingCommand doesn't have _prepare_state method
to do similar things, we can only use prepare_steps. But it's overkiller to
implement new steps for trivial things, like setting an option.

It is a dependency for the new run-tests-touched-by-attachment command,
see https://bugs.webkit.org/show_bug.cgi?id=117831#c3 for details.

[Csaba Osztrogonác]

Created attachment 205595 [details]
Patch

[Peter Gal]

View in context: https://bugs.webkit.org/attachment.cgi?id=205595&action=review

> Tools/ChangeLog:10
> +        (AbstractPatchSequencingCommand._prepare_to_process): Call _prepare_state before prepare_steps.

you mean prepare_sequence instead of the prepare_steps?

[Ryosuke Niwa]

Comment on attachment 205595 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205595&action=review

> Tools/ChangeLog:7
> +

You should probably mention that this is a preparation to fix some other bug.

[Csaba Osztrogonác]

Committed r152113: <http://trac.webkit.org/changeset/152113>