Bug 118127

Summary:

Add support for JavaScript "for-in" statement in DFG

Product:

WebKit

Reporter:

Vahag <vaag>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

buildbot, commit-queue, dm, fpizlo, joepeck, oliver, rniwa, zhroma

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Adds "for (in i object)" loop support in DFG.	none
Fixed style problems	msaboff: review-, buildbot: commit-queue-
Archive of layout-test-results from APPLE-EWS-5 for win-future	none
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2	none
Adds "for-in" statement support in DFG	none

Vahag

Reported 2013-06-27 05:21:32 PDT

Adds "for (in i object)" loop support in DFG.

Attachments
Adds "for (in i object)" loop support in DFG. (51.00 KB, patch) 2013-06-27 05:33 PDT, Vahag	no flags	Details Formatted Diff Diff
Fixed style problems (52.25 KB, patch) 2013-06-27 06:59 PDT, Vahag	msaboff: review- buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from APPLE-EWS-5 for win-future (813.16 KB, application/zip) 2013-06-27 13:37 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion (672.98 KB, application/zip) 2013-07-01 11:13 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 (521.26 KB, application/zip) 2013-07-04 01:11 PDT, Build Bot	no flags	Details
Adds "for-in" statement support in DFG (52.50 KB, patch) 2013-12-02 13:03 PST, Vahag	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Vahag

Comment 1 2013-06-27 05:33:50 PDT

Created attachment 205593 [details] Adds "for (in i object)" loop support in DFG.

WebKit Commit Bot

Comment 2 2013-06-27 05:36:08 PDT

Attachment 205593 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/bytecode/CodeBlock.cpp', u'Source/JavaScriptCore/bytecode/Opcode.h', u'Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp', u'Source/JavaScriptCore/dfg/DFGAbstractState.cpp', u'Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp', u'Source/JavaScriptCore/dfg/DFGCFGSimplificationPhase.cpp', u'Source/JavaScriptCore/dfg/DFGCapabilities.h', u'Source/JavaScriptCore/dfg/DFGFixupPhase.cpp', u'Source/JavaScriptCore/dfg/DFGNode.h', u'Source/JavaScriptCore/dfg/DFGNodeType.h', u'Source/JavaScriptCore/dfg/DFGOperations.cpp', u'Source/JavaScriptCore/dfg/DFGOperations.h', u'Source/JavaScriptCore/dfg/DFGPredictionPropagationPhase.cpp', u'Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp', u'Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h', u'Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp', u'Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp', u'Source/JavaScriptCore/jit/JITPropertyAccess.cpp', u'Source/JavaScriptCore/jit/JITPropertyAccess32_64.cpp', u'Source/JavaScriptCore/llint/LLIntSlowPaths.cpp', u'Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm', u'Source/JavaScriptCore/llint/LowLevelInterpreter64.asm', u'Source/JavaScriptCore/runtime/JSPropertyNameIterator.h', u'Source/JavaScriptCore/runtime/StructureChain.h']" exit_code: 1 Source/JavaScriptCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 25 files If any of these errors are false positives, please file a bug against check-webkit-style.

Vahag

Comment 3 2013-06-27 06:59:00 PDT

Created attachment 205601 [details] Fixed style problems

Build Bot

Comment 4 2013-06-27 13:37:38 PDT

Comment on attachment 205601 [details] Fixed style problems Attachment 205601 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/998082 New failing tests: fast/js/global-constructors-attributes-shared-worker.html fast/js/global-constructors-attributes-dedicated-worker.html

Build Bot

Comment 5 2013-06-27 13:37:40 PDT

Created attachment 205629 [details] Archive of layout-test-results from APPLE-EWS-5 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: APPLE-EWS-5 Port: win-future Platform: CYGWIN_NT-6.1-WOW64-1.7.20-0.266-5-3-i686-32bit

Build Bot

Comment 6 2013-07-01 11:13:12 PDT

Comment on attachment 205601 [details] Fixed style problems Attachment 205601 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1016091 New failing tests: http/tests/inspector/extensions-headers.html inspector/console/console-format.html inspector/console/console-format-style-whitelist.html http/tests/inspector/inspect-element.html inspector/styles/styles-computed-trace.html

Build Bot

Comment 7 2013-07-01 11:13:14 PDT

Created attachment 205823 [details] Archive of layout-test-results from webkit-ews-08 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-08 Port: mac-mountainlion Platform: Mac OS X 10.8.3

Build Bot

Comment 8 2013-07-04 01:11:00 PDT

Comment on attachment 205601 [details] Fixed style problems Attachment 205601 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1022423 New failing tests: inspector/console/console-format-style.html inspector/console/console-format.html http/tests/inspector/extensions-ignore-cache.html http/tests/inspector/inspect-element.html

Build Bot

Comment 9 2013-07-04 01:11:02 PDT

Created attachment 206060 [details] Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-15 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.3

Michael Saboff

Comment 10 2013-10-31 15:27:04 PDT

Comment on attachment 205601 [details] Fixed style problems Old bug cleanup… Please rebase, fix the test failures and submit a new patch.

Vahag

Comment 11 2013-12-02 13:03:34 PST

Created attachment 218207 [details] Adds "for-in" statement support in DFG

Vahag

Comment 12 2013-12-20 13:00:01 PST

Rebased and fixed. Could someone review please?

Joseph Pecoraro

Comment 13 2015-11-12 21:19:08 PST

It looks like "for..in" support was added to the DFG in bug 134142: https://bugs.webkit.org/show_bug.cgi?id=134142 Lets duplicate and clear patch review flags. *** This bug has been marked as a duplicate of bug 134142 ***

Note You need to log in before you can comment on or make changes to this bug.