Bug 118120

Summary: [CMake] Add STATICALLY_LINKED_WITH_WTF to JavaScriptCore project
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: Tools / TestsAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gyuyoung.kim, rakuco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch gyuyoung.kim: review+

Description Patrick R. Gansterer 2013-06-27 01:32:33 PDT 
[CMake] Add STATICALLY_LINKED_WITH_WTF to JavaScriptCore project
Comment 1 Patrick R. Gansterer 2013-06-27 01:40:45 PDT 
Created attachment 205574 [details]
Patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2013-06-30 09:41:10 PDT 
Comment on attachment 205574 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205574&action=review

LGTM.

> Source/JavaScriptCore/CMakeLists.txt:540
>  add_definitions(-DBUILDING_JavaScriptCore)
> +add_definitions(-DSTATICALLY_LINKED_WITH_WTF)

You could merge these into a single call.
Comment 3 Gyuyoung Kim 2013-06-30 19:07:49 PDT 
Comment on attachment 205574 [details]
Patch

Looks fine too.
Comment 4 Patrick R. Gansterer 2013-07-04 01:55:10 PDT 
Committed r152393: <http://trac.webkit.org/changeset/152393>