Summary: | [CMake] Add STATICALLY_LINKED_WITH_WTF to JavaScriptCore project | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Patrick R. Gansterer <paroga> | ||||
Component: | Tools / Tests | Assignee: | Patrick R. Gansterer <paroga> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, gyuyoung.kim, rakuco | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Patrick R. Gansterer
2013-06-27 01:32:33 PDT
Created attachment 205574 [details]
Patch
Comment on attachment 205574 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205574&action=review LGTM. > Source/JavaScriptCore/CMakeLists.txt:540 > add_definitions(-DBUILDING_JavaScriptCore) > +add_definitions(-DSTATICALLY_LINKED_WITH_WTF) You could merge these into a single call. Comment on attachment 205574 [details]
Patch
Looks fine too.
Committed r152393: <http://trac.webkit.org/changeset/152393> |