Bug 118115

Summary:

Avoid duplicating hostWindow() call in FrameView::setFrameRect()

Product:

WebKit

Reporter:

Seokju Kwon <seokju>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Seokju Kwon

Reported 2013-06-26 22:09:52 PDT

Patch follows.

Attachments
Patch (1.31 KB, patch) 2013-06-26 22:11 PDT, Seokju Kwon	no flags	Details Formatted Diff Diff
Patch (1.36 KB, patch) 2013-06-27 06:50 PDT, Seokju Kwon	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Seokju Kwon

Comment 1 2013-06-26 22:11:40 PDT

Created attachment 205561 [details] Patch

Chris Dumez

Comment 2 2013-06-27 04:21:35 PDT

Comment on attachment 205561 [details] Patch FrameView::hostWindow() is not trivial/inlined so ok. r=me.

Chris Dumez

Comment 3 2013-06-27 04:22:04 PDT

Comment on attachment 205561 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205561&action=review > Source/WebCore/ChangeLog:7 > + Please add a Changelog.

Seokju Kwon

Comment 4 2013-06-27 06:50:55 PDT

Created attachment 205598 [details] Patch

Seokju Kwon

Comment 5 2013-06-27 06:51:30 PDT

Comment on attachment 205598 [details] Patch Fixed it. Thanks!

WebKit Commit Bot

Comment 6 2013-06-27 08:12:09 PDT

Comment on attachment 205598 [details] Patch Clearing flags on attachment: 205598 Committed r152098: <http://trac.webkit.org/changeset/152098>

WebKit Commit Bot

Comment 7 2013-06-27 08:12:11 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.