Bug 118093

Summary: Kill updateStyleForAllDocuments()
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Layout and RenderingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, darin, hyatt, psolanki, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ggaren: review+

Description Simon Fraser (smfr) 2013-06-26 15:29:32 PDT 
There is no reason we should ever have to call Document::updateStyleForAllDocuments(), yet JSCallbackData::invokeCallback() and JSCustomXPathNSResolver::lookupNamespaceURI() both do so.
Comment 1 Simon Fraser (smfr) 2013-07-29 22:11:23 PDT 
I tried this. The only new test failure is editing/selection/leak-document-with-selection-inside.html which makes bogus assumptions about how long documents live.
Comment 2 Simon Fraser (smfr) 2013-07-29 22:14:51 PDT 
(In reply to comment #1)
> I tried this. The only new test failure is editing/selection/leak-document-with-selection-inside.html which makes bogus assumptions about how long documents live.

Actually it's just flakey. It fails without any change.
Comment 3 Simon Fraser (smfr) 2013-07-29 22:23:39 PDT 
Created attachment 207687 [details]
Patch
Comment 4 Simon Fraser (smfr) 2013-07-29 22:31:17 PDT 
This patch removes the callers. If it passes EWS I'll remove the function too.
Comment 5 Geoffrey Garen 2013-07-29 23:32:15 PDT 
Comment on attachment 207687 [details]
Patch

r=me
Comment 6 Alexey Proskuryakov 2013-07-30 10:27:47 PDT 
See also: bug 46761. Good to hear that tests are no longer failing, although EWS is in such shape that it probably won’t provide a trustworthy answer.

Looks like we still have a caller in Element::setActive()?
Comment 7 Alexey Proskuryakov 2013-07-30 10:29:27 PDT 
See also discussion in bug 32580.
Comment 8 Simon Fraser (smfr) 2013-07-30 10:42:58 PDT 
http://trac.webkit.org/changeset/42384 is related.
Comment 9 Simon Fraser (smfr) 2013-08-08 17:46:51 PDT 
https://trac.webkit.org/r153872