Bug 118080

Summary: [CSS Shapes] New positioning model: basic support for rectangle shape-outside
Product: WebKit Reporter: Bem Jones-Bey <bjonesbe>
Component: CSSAssignee: Bem Jones-Bey <bjonesbe>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kling, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://dev.w3.org/csswg/css-shapes/#relation-to-box-model-and-float-behavior
Bug Depends on: 118502    
Bug Blocks: 117898    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from APPLE-EWS-5 for win-future
none
Patch none

Bem Jones-Bey
Reported 2013-06-26 14:31:24 PDT
Implement the new positioning model, and have it work for basic rectangles.
Attachments
Patch (104.80 KB, patch)
2013-06-26 18:18 PDT, Bem Jones-Bey 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from APPLE-EWS-5 for win-future (1.01 MB, application/zip)
2013-06-27 02:13 PDT, Build Bot 		no flags
Details
Patch (109.83 KB, patch)
2013-06-27 10:38 PDT, Bem Jones-Bey 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Bem Jones-Bey
Comment 1 2013-06-26 18:18:17 PDT
Created attachment 205551 [details] Patch Initial implementation of new positioning model. Passes simple tests.
Build Bot
Comment 2 2013-06-27 02:13:38 PDT
Comment on attachment 205551 [details] Patch Attachment 205551 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/987191 New failing tests: csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-002.html csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-002.html csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-000.html csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-001.html csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-000.html csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-001.html csswg/submitted/shapes/shape-outside/shape-outside-floats-square-000.html
Build Bot
Comment 3 2013-06-27 02:13:41 PDT
Created attachment 205579 [details] Archive of layout-test-results from APPLE-EWS-5 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: APPLE-EWS-5 Port: win-future Platform: CYGWIN_NT-6.1-WOW64-1.7.20-0.266-5-3-i686-32bit
Bem Jones-Bey
Comment 4 2013-06-27 10:38:25 PDT
Created attachment 205619 [details] Patch Fix tests.
Dave Hyatt
Comment 5 2013-06-27 12:49:10 PDT
Comment on attachment 205619 [details] Patch r=me, good to get rid of the confusing paintOffset() stuff.
WebKit Commit Bot
Comment 6 2013-06-27 13:33:40 PDT
Comment on attachment 205619 [details] Patch Clearing flags on attachment: 205619 Committed r152122: <http://trac.webkit.org/changeset/152122>
WebKit Commit Bot
Comment 7 2013-06-27 13:33:42 PDT
All reviewed patches have been landed. Closing bug.
Andreas Kling
Comment 8 2013-06-27 22:27:44 PDT
Some of the pixel tests added are failing on Apple Win: http://build.webkit.org/results/Apple%20Win%207%20Release%20(Tests)/r152122%20(36876)/results.html
Bem Jones-Bey
Comment 9 2013-06-28 07:55:25 PDT
(In reply to comment #8) > Some of the pixel tests added are failing on Apple Win: > > http://build.webkit.org/results/Apple%20Win%207%20Release%20(Tests)/r152122%20(36876)/results.html Hrm. Looks like I got bitten by moving the tests, since the fast/exclusions directory is excluded on Windows. I'll add the expectation for the csswg/submitted/shapes directory as well. The patch is in Bug 118192.
Note You need to log in before you can comment on or make changes to this bug.