| Summary: | [CSS Shapes] New positioning model: basic support for rectangle shape-outside | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Bem Jones-Bey <bjonesbe> | ||||||||
| Component: | CSS | Assignee: | Bem Jones-Bey <bjonesbe> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, esprehn+autocc, glenn, kling, simon.fraser | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| URL: | http://dev.w3.org/csswg/css-shapes/#relation-to-box-model-and-float-behavior | ||||||||||
| Bug Depends on: | 118502 | ||||||||||
| Bug Blocks: | 117898 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Bem Jones-Bey
2013-06-26 14:31:24 PDT
Created attachment 205551 [details]
Patch
Initial implementation of new positioning model. Passes simple tests.
Comment on attachment 205551 [details] Patch Attachment 205551 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/987191 New failing tests: csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-002.html csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-002.html csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-000.html csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-001.html csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-000.html csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-001.html csswg/submitted/shapes/shape-outside/shape-outside-floats-square-000.html Created attachment 205579 [details]
Archive of layout-test-results from APPLE-EWS-5 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: APPLE-EWS-5 Port: win-future Platform: CYGWIN_NT-6.1-WOW64-1.7.20-0.266-5-3-i686-32bit
Created attachment 205619 [details]
Patch
Fix tests.
Comment on attachment 205619 [details]
Patch
r=me, good to get rid of the confusing paintOffset() stuff.
Comment on attachment 205619 [details] Patch Clearing flags on attachment: 205619 Committed r152122: <http://trac.webkit.org/changeset/152122> All reviewed patches have been landed. Closing bug. Some of the pixel tests added are failing on Apple Win: http://build.webkit.org/results/Apple%20Win%207%20Release%20(Tests)/r152122%20(36876)/results.html (In reply to comment #8) > Some of the pixel tests added are failing on Apple Win: > > http://build.webkit.org/results/Apple%20Win%207%20Release%20(Tests)/r152122%20(36876)/results.html Hrm. Looks like I got bitten by moving the tests, since the fast/exclusions directory is excluded on Windows. I'll add the expectation for the csswg/submitted/shapes directory as well. The patch is in Bug 118192. |