Bug 118078

Summary:

Polish context menus for media elements

Product:

WebKit

Reporter:

Ruth Fong <ruthiecftg>

Component:

Media

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, eflews.bot, eric.carlson, gyuyoung.kim, jer.noble, jonlee, philn, rakuco, rego+ews, ruthiecftg, thorton, webkit-ews, xan.lopez

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Ruth Fong

Reported 2013-06-26 14:04:22 PDT

The "Controls" context menu item for media elements should be changed to a toggle-able item "Show Controls"/"Hide Controls" for clarity's sake.

Attachments
Patch (7.11 KB, patch) 2013-06-26 14:20 PDT, Ruth Fong	no flags	Details Formatted Diff Diff
Patch (11.08 KB, patch) 2013-06-26 16:06 PDT, Ruth Fong	no flags	Details Formatted Diff Diff
Patch (13.57 KB, patch) 2013-06-26 16:38 PDT, Ruth Fong	no flags	Details Formatted Diff Diff
Patch (10.33 KB, patch) 2013-06-26 16:51 PDT, Ruth Fong	no flags	Details Formatted Diff Diff
Patch (9.61 KB, patch) 2013-06-27 10:05 PDT, Ruth Fong	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Ruth Fong

Comment 1 2013-06-26 14:09:07 PDT

<rdar://problem/14278960>

Ruth Fong

Comment 2 2013-06-26 14:10:56 PDT

Also, change "Fullscreen" to "Full Screen".

Ruth Fong

Comment 3 2013-06-26 14:20:05 PDT

Created attachment 205525 [details] Patch

EFL EWS Bot

Comment 4 2013-06-26 14:27:56 PDT

Comment on attachment 205525 [details] Patch Attachment 205525 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/963723

Early Warning System Bot

Comment 5 2013-06-26 14:30:50 PDT

Comment on attachment 205525 [details] Patch Attachment 205525 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/892302

Early Warning System Bot

Comment 6 2013-06-26 14:31:17 PDT

Comment on attachment 205525 [details] Patch Attachment 205525 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/892301

EFL EWS Bot

Comment 7 2013-06-26 14:36:39 PDT

Comment on attachment 205525 [details] Patch Attachment 205525 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/986114

Ruth Fong

Comment 8 2013-06-26 16:06:24 PDT

Created attachment 205533 [details] Patch

Early Warning System Bot

Comment 9 2013-06-26 16:14:35 PDT

Comment on attachment 205533 [details] Patch Attachment 205533 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/963750

Early Warning System Bot

Comment 10 2013-06-26 16:16:38 PDT

Comment on attachment 205533 [details] Patch Attachment 205533 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/946429

EFL EWS Bot

Comment 11 2013-06-26 16:18:29 PDT

Comment on attachment 205533 [details] Patch Attachment 205533 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/990223

EFL EWS Bot

Comment 12 2013-06-26 16:30:52 PDT

Comment on attachment 205533 [details] Patch Attachment 205533 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/945709

Ruth Fong

Comment 13 2013-06-26 16:38:14 PDT

Created attachment 205539 [details] Patch

Early Warning System Bot

Comment 14 2013-06-26 16:46:32 PDT

Comment on attachment 205539 [details] Patch Attachment 205539 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/869839

Early Warning System Bot

Comment 15 2013-06-26 16:48:53 PDT

Comment on attachment 205539 [details] Patch Attachment 205539 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/948384

Ruth Fong

Comment 16 2013-06-26 16:51:58 PDT

Created attachment 205542 [details] Patch

Eric Carlson

Comment 17 2013-06-27 09:58:42 PDT

Comment on attachment 205542 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205542&action=review > Source/WebCore/ChangeLog:9 > + No new tests. media/context-menu-action.html, Nit: I think you meant to use a comma instead of a period here. > Source/WebKit2/ChangeLog:13 > +2013-06-26 Ruth Fong <ruth_fong@apple.com> > + > + Polish context menus for media elements > + https://bugs.webkit.org/show_bug.cgi?id=118078 > + <rdar://problem/14278960> > + > + Reviewed by NOBODY (OOPS!). > + > + * Shared/API/c/WKContextMenuItemTypes.h: > + * Shared/API/c/WKSharedAPICast.h: > + Added new type of context menu item that allows > + toggling between "Show Controls" and "Hide Controls". > + This is not needed.

Ruth Fong

Comment 18 2013-06-27 10:05:19 PDT

Created attachment 205616 [details] Patch

WebKit Commit Bot

Comment 19 2013-06-27 11:14:23 PDT

Comment on attachment 205616 [details] Patch Clearing flags on attachment: 205616 Committed r152117: <http://trac.webkit.org/changeset/152117>

WebKit Commit Bot

Comment 20 2013-06-27 11:14:27 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.