Bug 118064

Summary: Match CanvasGradient::addColorStop to the spec.
Product: WebKit Reporter: Dongseong Hwang <dongseong.hwang>
Component: CanvasAssignee: Dongseong Hwang <dongseong.hwang>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: ap, benjamin, cdumez, commit-queue, darin, dino, esprehn+autocc, Ms2ger, rniwa
Priority: P2 Keywords: BlinkMergeCandidate, WebExposed
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch krit: review+, krit: commit-queue-

Dongseong Hwang
Reported 2013-06-26 08:57:01 PDT
The canvas spec [1] defines addColorStop without optional arguments. This patch removes optional attribute from addColorStop interface. [1] http://www.w3.org/TR/2dcontext2/
Attachments
Patch (3.11 KB, patch)
2013-06-26 09:00 PDT, Dongseong Hwang 		krit: review+
krit: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dongseong Hwang
Comment 1 2013-06-26 09:00:42 PDT
Created attachment 205501 [details] Patch
Dongseong Hwang
Comment 2 2013-06-26 09:01:22 PDT
This patch is backported from Blink : https://chromiumcodereview.appspot.com/14798006
Chris Dumez
Comment 3 2013-06-26 10:09:16 PDT
(In reply to comment #2) > This patch is backported from Blink : https://chromiumcodereview.appspot.com/14798006 "cherry-pick" or "ported" would be more accurate than "backport" here :)
Chris Dumez
Comment 4 2013-06-26 10:25:10 PDT
Comment on attachment 205501 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205501&action=review LGTM but someone else should confirm as this is a web exposed change. > Source/WebCore/ChangeLog:9 > + removes optional attribute from addColorStop interface. nit: "removes the optional keyword from addColorStop operation arguments."
Dongseong Hwang
Comment 5 2013-06-27 06:05:01 PDT
(In reply to comment #4) > (From update of attachment 205501 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=205501&action=review > > LGTM but someone else should confirm as this is a web exposed change. > > > Source/WebCore/ChangeLog:9 > > + removes optional attribute from addColorStop interface. > > nit: "removes the optional keyword from addColorStop operation arguments." Thank you for review! I'll fix nit :)
Dirk Schulze
Comment 6 2014-04-03 01:43:55 PDT
*** Bug 118011 has been marked as a duplicate of this bug. ***
Dirk Schulze
Comment 7 2014-04-03 01:44:50 PDT
Comment on attachment 205501 [details] Patch r=me. I hope you can still land this bug. But please fix the change log.
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 8 2017-09-18 01:52:14 PDT
This was eventually fixed in bug 160297. *** This bug has been marked as a duplicate of bug 160297 ***
Note You need to log in before you can comment on or make changes to this bug.