Bug 118054

Summary: Use & instead of | in the value of [CallWith]
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, esprehn+autocc, graouts, haraken, joepeck, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2013-06-26 03:45:01 PDT
[CallWith=ScriptExecutionContext|ScriptState] meant that both the ScriptExecutionContext AND the ScriptState would be passed as arguments to the implementation (not one OR the other). We should use [CallWith=ScriptExecutionContext&ScriptState] for clarity.
Attachments
Patch (8.10 KB, patch)
2013-06-26 04:08 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (7.19 KB, patch)
2013-06-27 23:23 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2013-06-26 04:08:58 PDT
Created attachment 205468 [details] Patch
Kentaro Hara
Comment 2 2013-06-26 04:45:43 PDT
Comment on attachment 205468 [details] Patch Makes sense.
Chris Dumez
Comment 3 2013-06-27 23:23:42 PDT
Created attachment 205670 [details] Patch
WebKit Commit Bot
Comment 4 2013-06-28 01:20:52 PDT
Comment on attachment 205670 [details] Patch Clearing flags on attachment: 205670 Committed r152154: <http://trac.webkit.org/changeset/152154>
WebKit Commit Bot
Comment 5 2013-06-28 01:20:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.