Bug 118054

Summary:

Use & instead of | in the value of [CallWith]

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Bindings

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, darin, esprehn+autocc, graouts, haraken, joepeck, timothy

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Chris Dumez 2013-06-26 03:45:01 PDT

[CallWith=ScriptExecutionContext|ScriptState] meant that both the ScriptExecutionContext AND the ScriptState would be passed as arguments to the implementation (not one OR the other).

We should use [CallWith=ScriptExecutionContext&ScriptState] for clarity.

Comment 1 Chris Dumez 2013-06-26 04:08:58 PDT

Created attachment 205468 [details]
Patch

Comment 2 Kentaro Hara 2013-06-26 04:45:43 PDT

Comment on attachment 205468 [details]
Patch

Makes sense.

Comment 3 Chris Dumez 2013-06-27 23:23:42 PDT

Created attachment 205670 [details]
Patch

Comment 4 WebKit Commit Bot 2013-06-28 01:20:52 PDT

Comment on attachment 205670 [details]
Patch

Clearing flags on attachment: 205670

Committed r152154: <http://trac.webkit.org/changeset/152154>

Comment 5 WebKit Commit Bot 2013-06-28 01:20:54 PDT

All reviewed patches have been landed.  Closing bug.